Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

Commit 62529e3

Browse files
author
Chelsea Mafrica
committed
virtcontainers: Add msg to existing utils unit tests
Add message to existing unit tests that use arrays and loops for easier debugging. Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>
1 parent 5debe06 commit 62529e3

1 file changed

Lines changed: 19 additions & 14 deletions

File tree

virtcontainers/utils/utils_test.go

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
package utils
77

88
import (
9+
"fmt"
910
"io/ioutil"
1011
"os"
1112
"path/filepath"
@@ -199,10 +200,11 @@ func TestGetVirtDriveName(t *testing.T) {
199200
{18277, "vdzzz"},
200201
}
201202

202-
for _, test := range tests {
203+
for i, test := range tests {
204+
msg := fmt.Sprintf("test[%d]: %+v", i, test)
203205
driveName, err := GetVirtDriveName(test.index)
204-
assert.NoError(err)
205-
assert.Equal(driveName, test.expectedDrive)
206+
assert.NoError(err, msg)
207+
assert.Equal(driveName, test.expectedDrive, msg)
206208
}
207209
}
208210

@@ -225,11 +227,12 @@ func TestGetSCSIIdLun(t *testing.T) {
225227
{513, 2, 1},
226228
}
227229

228-
for _, test := range tests {
230+
for i, test := range tests {
231+
msg := fmt.Sprintf("test[%d]: %+v", i, test)
229232
scsiID, lun, err := GetSCSIIdLun(test.index)
230-
assert.NoError(err)
231-
assert.Equal(scsiID, test.expectedScsiID)
232-
assert.Equal(lun, test.expectedLun)
233+
assert.NoError(err, msg)
234+
assert.Equal(scsiID, test.expectedScsiID, msg)
235+
assert.Equal(lun, test.expectedLun, msg)
233236
}
234237

235238
_, _, err := GetSCSIIdLun(-1)
@@ -251,10 +254,11 @@ func TestGetSCSIAddress(t *testing.T) {
251254
{512, "2:0"},
252255
}
253256

254-
for _, test := range tests {
257+
for i, test := range tests {
258+
msg := fmt.Sprintf("test[%d]: %+v", i, test)
255259
scsiAddr, err := GetSCSIAddress(test.index)
256-
assert.NoError(err)
257-
assert.Equal(scsiAddr, test.expectedSCSIAddress)
260+
assert.NoError(err, msg)
261+
assert.Equal(scsiAddr, test.expectedSCSIAddress, msg)
258262
}
259263

260264
_, err := GetSCSIAddress(-1)
@@ -299,15 +303,16 @@ func TestBuildSocketPath(t *testing.T) {
299303

300304
for i, d := range data {
301305
result, err := BuildSocketPath(d.elems...)
306+
msg := fmt.Sprintf("test[%d]: %+v", i, d)
302307

303308
if d.valid {
304-
assert.NoErrorf(err, "test %d, data %+v", i, d)
309+
assert.NoErrorf(err, "test %d, data %+v", i, d, msg)
305310
} else {
306-
assert.Errorf(err, "test %d, data %+v", i, d)
311+
assert.Errorf(err, "test %d, data %+v", i, d, msg)
307312
}
308313

309-
assert.NotNil(result)
310-
assert.Equal(d.expected, result)
314+
assert.NotNil(result, msg)
315+
assert.Equal(d.expected, result, msg)
311316
}
312317
}
313318

0 commit comments

Comments
 (0)