Add cookieMaxAge and secureCookies options#1612
Merged
MadeByMike merged 8 commits intomasterfrom Sep 11, 2019
Merged
Conversation
🦋 Changeset is good to goLatest commit: 69a3196 We got this. Not sure what this means? Click here to learn what changesets are. |
Contributor
|
Yeah, it's starting to get a bit crowded there. I'm thinking perhaps we have a One thing I realised about #1596 is the |
jesstelford
reviewed
Sep 11, 2019
jesstelford
reviewed
Sep 11, 2019
Contributor
Yeah, I'm a big fan of that kind of grouping. Doesn't have to be on this PR, but something to consider for the future. |
MadeByMike
force-pushed
the
session-security
branch
from
29186ac to
a5db0f8
Compare
MadeByMike
force-pushed
the
session-security
branch
from
a5db0f8 to
24aa382
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1596 and #1595
I followed the pattern of adding options to the keystone object. Not sure if I should have grouped these under cookies or something, we're getting quite a few config options here and I'm not sure these should be on the Keystone constructor?
We could probably save the above for a more general discussion in future.
For both options I've set defaults for
devandproduction- Can you check these are right?Can I also get some help on how best to test this? Commits welcome.