Add CHANGELOG and Github Tag to release page by kfess · Pull Request #54740 · kubernetes/website

kfess · 2026-03-01T15:25:33Z

Description

Add CHANGELOG and GitHub tag links to release series pages for all versions.

Issue

netlify · 2026-03-01T15:35:36Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`40c4b8f`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/69ae9d3d33d64300083b4553
😎 Deploy Preview	https://deploy-preview-54740--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

CodesbyUnnati · 2026-03-03T11:33:48Z

/lgtm

k8s-ci-robot · 2026-03-03T11:33:53Z

@CodesbyUnnati: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lmktfy · 2026-03-05T17:53:54Z

/sig release
/area web-development

lmktfy

Thanks. We can just about merge it as-is, but it will be considerably better with tweaks.

lmktfy · 2026-03-05T17:55:18Z

layouts/docs/release-series.html

    </li>
+    {{ end }}
+    <li>
+      <a href="https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-{{ .Params.minorVersion }}.md">


For v1.35 the right place to link to is likely to be https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.35.md#changelog-since-v1340

I think we could try to work out the fragment to target (automatically, I mean); if we get that part wrong, it degrades to a less good but still useful experience for the user.

Agreed, linking directly to the relevant section would be a better experience. I'll work on generating the fragment automatically.

The anchor format for changelogs varies across older versions (e.g., "changes-since" vs "changelog-since", inconsistent hash patterns). So it required version-specific branching to generate the correct link.

Eesh. We might be able to get that fixed retrospectively or something.

OK. Well, then, it doesn't block a merge.

I also think this logic is ugly. Recent releases already use a consistent anchor format, so if we could fix the old CHANGELOGs, we could remove all this branching logic entirely.
I'm not sure if changing historical CHANGELOGs is acceptable or not, but is it worth filing an issue to discuss at kubernetes/kubernetes?

lmktfy · 2026-03-05T17:57:16Z

layouts/docs/release-series.html

      {{ end }}
    </li>
+    {{ end }}
+    <li>


I'd use

{{- $currentVersion := site.Params.version -}} {{- $currentVersion := (replace $currentVersion "v" "") -}}

matching https://github.com/kubernetes/website/blob/fb51996b2ede0aec5ab329cb5816ce8bd1a28f4c/layouts/shortcodes/skew.html (the skew shortcode)

The same question with https://github.com/kubernetes/website/pull/54740/changes#r2898768439

Thanks for the suggestion. Currently, isLatestVersion is computed in the content adapter (_content.gotmpl) by comparing against the first entry in site.Data.releases.schedule.schedules.

Do you mean that passing this data via .Params from the content adapter is not preferred?

Ah, I mistook these for global params. Oops.

lmktfy · 2026-03-05T17:58:52Z

layouts/docs/release-series.html

+    </li>
+    <li>
+      <a href="https://github.com/kubernetes/kubernetes/releases/tag/v{{ .Params.latestPatchVersion }}">
+        {{ T "release_github_tag" }} ({{ .Params.latestPatchVersion }})


The best way to get the patch version is actually similar to this code:

 {{- if eq $version "currentPatchVersion" -}} {{- $seenPatchVersionInfoCount := 0 }} {{- range $releaseInfo := .Site.Data.releases.schedule.schedules -}} {{- if eq $currentVersion ( printf "%.2f" $releaseInfo.release ) -}} {{- range $patchReleaseInfo := $releaseInfo.previousPatches -}} {{- if eq $seenPatchVersionInfoCount 0 -}} {{- $patchReleaseInfo.release -}} {{- end -}} {{- $seenPatchVersionInfoCount = add $seenPatchVersionInfoCount 1 -}} {{- end -}} {{- end -}} {{- end -}} {{- if eq $seenPatchVersionInfoCount 0 -}}  {{- printf "%s.0" $currentVersion -}} {{- end -}} {{- end -}}

This lookup that I've quoted relies on changes that are automatically processed (using a process owned by SIG Release); .Params.latestPatchVersion is legacy.

Just to clarify, .Params.latestPatchVersion is computed in the content adapter (_content.gotmpl).
For supported versions, it comes from site.Data.releases.schedule.schedules[].previousPatches.
For eol versions, it comes from site.Data.releases.eol.branches[].finalPatchRelease.

Do you mean that passing this data via .Params from the content adapter is not a preferred approach?

Ah, I mistook these for global params. Sorry about that.

It's good to have a defensive calculation where if previousPatches doesn't have any data, we fall back to patch version 0 though.

lmktfy · 2026-03-05T18:00:27Z

Aside: we used to have https://relnotes.k8s.io/ but it is very stale.

lmktfy · 2026-03-08T17:23:08Z

content/en/releases/_content.gotmpl

  {{ $parts := split $version "." }}
  {{ $major := int (index $parts 0) }}
  {{ $minor := int (index $parts 1) }}
+  {{ $previousMinorVersion := printf "%d.%d" $major (sub $minor 1) }}


Maybe add a comment that this is fragile if we ever do a major version release (Kubernetes 2.0)

lmktfy · 2026-03-08T17:24:45Z

/lgtm

k8s-ci-robot · 2026-03-08T17:24:52Z

LGTM label has been added.

Details

Git tree hash: 7b41591e14de1d69b627692b53564c7848488f59

kfess · 2026-03-09T10:15:26Z

I've updated the commits to incorporate the latest changes. Please take a look when you have time.

natalisucks · 2026-03-09T10:58:39Z

thank you @kfess 🚀
/approve

k8s-ci-robot · 2026-03-09T10:58:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [natalisucks]
~~content/en/releases/OWNERS~~ [natalisucks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lmktfy · 2026-03-11T19:23:51Z

/lgtm

k8s-ci-robot · 2026-03-11T19:23:59Z

LGTM label has been added.

Details

Git tree hash: 51ba6d12bea605d466ccd6a5804ee5bb12a3fab5

k8s-ci-robot requested a review from natalisucks March 1, 2026 15:25

k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 1, 2026

k8s-ci-robot requested a review from reylejano March 1, 2026 15:25

k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 1, 2026

k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes labels Mar 5, 2026

lmktfy reviewed Mar 5, 2026

View reviewed changes

kfess force-pushed the issue-54739 branch from 6c43eff to 45a4b26 Compare March 8, 2026 15:44

k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2026

lmktfy reviewed Mar 8, 2026

View reviewed changes

k8s-ci-robot assigned lmktfy Mar 8, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2026

add github tag and changelog to release page

40c4b8f

kfess force-pushed the issue-54739 branch from 45a4b26 to 40c4b8f Compare March 9, 2026 10:13

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2026

k8s-ci-robot requested a review from lmktfy March 9, 2026 10:13

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2026

k8s-ci-robot merged commit 54e0666 into kubernetes:main Mar 11, 2026
6 checks passed

kfess deleted the issue-54739 branch March 12, 2026 11:42

Conversation

kfess commented Mar 1, 2026

Description

Issue

Uh oh!

netlify bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Pull request preview available for checking

Uh oh!

CodesbyUnnati commented Mar 3, 2026

Uh oh!

k8s-ci-robot commented Mar 3, 2026

Uh oh!

lmktfy commented Mar 5, 2026

Uh oh!

lmktfy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kfess Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lmktfy commented Mar 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lmktfy commented Mar 8, 2026

Uh oh!

k8s-ci-robot commented Mar 8, 2026

Uh oh!

kfess commented Mar 9, 2026

Uh oh!

natalisucks commented Mar 9, 2026

Uh oh!

k8s-ci-robot commented Mar 9, 2026

Uh oh!

lmktfy commented Mar 11, 2026

Uh oh!

k8s-ci-robot commented Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

netlify bot commented Mar 1, 2026 •

edited

Loading

kfess Mar 7, 2026 •

edited

Loading