[mirrororch]: Fix bug: return false when SAI API call fails (sonic-net#607)

Shuotian Cheng · qiluo-msft · commit 6d40d850f34b · 2018-09-06T10:29:26.000-07:00
diff --git a/orchagent/mirrororch.cpp b/orchagent/mirrororch.cpp
@@ -528,6 +528,8 @@ bool MirrorOrch::activateSession(const string& name, MirrorEntry& session)
     {
         SWSS_LOG_ERROR("Failed to activate mirroring session %s\n", name.c_str());
         session.status = false;
+
+        return false;
     }
 
     session.status = true;

Original file line number	Diff line number	Diff line change
`@@ -528,6 +528,8 @@ bool MirrorOrch::activateSession(const string& name, MirrorEntry& session)`
`528`	`528`	`{`
`529`	`529`	`SWSS_LOG_ERROR("Failed to activate mirroring session %s\n", name.c_str());`
`530`	`530`	`session.status = false;`
	`531`	`+`
	`532`	`+ return false;`
`531`	`533`	`}`
`532`	`534`
`533`	`535`	`session.status = true;`