feat: add high-level connection and stream progress events#3429
Merged
Conversation
Member
Author
|
Depends on: |
achingbrain
force-pushed
the
feat/add-connection-and-stream-progress-events
branch
from
b16629c to
bb43f63
Compare
Where an operation might involve multiple libp2p operations - opening connections and streams, it is useful to be able to track which connections and streams are being opened, to which peers and how long it takes using the same `onProgress` callback. Add 4x new progress events with enough context in the event object to track these activities during calls to `libp2p.dial`, `libp2p.dialProtocol` and `connection.newStream`: - `connection:open` - `connection:opened` - `connection:open-stream` - `connection:opened-stream`
achingbrain
force-pushed
the
feat/add-connection-and-stream-progress-events
branch
from
197c91d to
b624f17
Compare
3 tasks
dozyio
approved these changes
Apr 2, 2026
Collaborator
|
Thanks @achingbrain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where an operation might involve multiple libp2p operations - opening connections and streams, it is useful to be able to track which connections and streams are being opened, to which peers and how long it takes using the same
onProgresscallback.Add 4x new progress events with enough context in the event object to track these activities during calls to
libp2p.dial,libp2p.dialProtocolandconnection.newStream:connection:openconnection:openedconnection:open-streamconnection:opened-streamUses
connection:xxxevent names to not tie the event names to internal libp2p architecture (e.g.connection:openinstead ofconnection-manager:open-connection).Updates libp2p interface and relevant protocols to use progress event types that contain the relevant events.
Change checklist