fix: Discover new glimmer components when they are added while watching.

Also verify that files can be removed without causing any issues.

Author: chriseppstein

packages/@css-blocks/broccoli/test/Analyze.ts

@@ -148,6 +148,51 @@ describe("Broccoli Analyze Plugin Test", function () {
       await output.build();
       assert.equal(transport["css"], "Transport Not Modified On NO-OP");
       assert.deepEqual(output.changes(), {});
+
+      // Adding a template & block is safe
+      input.write({
+        src: {
+          ui: {
+            components: {
+              [entryComponentName]: {
+                "template.hbs": `<div><h1>Welcome to Glimmer!</h1><AnotherComponent /></div>`,
+              },
+              AnotherComponent: {
+                "template.hbs": `<div block:scope><h1 block:class="bar">Another Component</h1></div>`,
+                "stylesheet.css": `:scope { border: 1px solid black; } .bar { border-left: 0px; }`,
+              },
+            },
+          },
+        },
+      });
+      await output.build();
+      assert.equal(transport["css"],
+                   `.a { color: red; }\n` +
+                   `.b { border: 1px solid black; } .c { border-left: 0px; }`,
+                   "Addition of new component compiles it.");
+      assert.deepEqual(output.changes(), {
+        "src/ui/components/Chrisrng/template.hbs": "change",
+        "src/ui/components/AnotherComponent/": "mkdir",
+        "src/ui/components/AnotherComponent/template.hbs": "create",
+      });
+
+      // Removing a template is safe
+      input.write({
+        src: {
+          ui: {
+            components: {
+              AnotherComponent: {
+                "template.hbs": null,
+                "stylesheet.css": null,
+              },
+            },
+          },
+        },
+      });
+      await output.build();
+      assert.deepEqual(output.changes(),
+                       { "src/ui/components/AnotherComponent/template.hbs": "unlink" },
+                       "output directory is cleaned up.");
     });
   });
 });

packages/@css-blocks/glimmer/src/Analyzer.ts

@@ -24,6 +24,7 @@ export class GlimmerAnalyzer extends Analyzer<TEMPLATE_TYPE> {
   blockFactory: BlockFactory;
   resolver: Resolver;
   debug: debugGenerator.IDebugger;
+  private moduleConfig: ResolverConfiguration | undefined;
 
   constructor(
     blockFactory: BlockFactory,
@@ -32,11 +33,13 @@ export class GlimmerAnalyzer extends Analyzer<TEMPLATE_TYPE> {
   ) {
     super(blockFactory, analysisOpts);
     this.blockFactory = blockFactory;
+    this.moduleConfig = moduleConfig;
     this.resolver = new Resolver(blockFactory.configuration, moduleConfig);
     this.debug = debugGenerator("css-blocks:glimmer:analyzer");
   }
 
   reset() {
+    this.resolver = new Resolver(this.blockFactory.configuration, this.moduleConfig);
     super.reset();
     this.blockFactory.reset();
   }
@@ -86,7 +89,7 @@ export class GlimmerAnalyzer extends Analyzer<TEMPLATE_TYPE> {
       }
       return await this.blockFactory.getBlockFromPath(blockFile.path);
     } catch (e) {
-      console.error(e);
+      this.debug(e);
       this.debug(`Analyzing ${componentName}. No block for component. Returning empty analysis.`);
       return undefined;
     }

packages/@css-blocks/glimmer/src/Resolver.ts

@@ -146,7 +146,9 @@ export class Resolver {
   recursiveDependenciesForTemplate(base: string, identifier: string): string[] {
     let depAnalyzer = this.dependencyAnalyzerFor(base);
     if (!depAnalyzer) { return [identifier]; }
-    return depAnalyzer.recursiveDependenciesForTemplate(identifier).components;
+    let results = depAnalyzer.recursiveDependenciesForTemplate(identifier).components;
+    DEBUG("Recursively discovered components: %s", results);
+    return results;
   }
 
   /**