Skip to content

perf(routers): add placeholder to avoid loop call#121

Merged
linrongbin16 merged 6 commits intomasterfrom
perf-add-placeholder-to-avoid-mis-using
Nov 16, 2023
Merged

perf(routers): add placeholder to avoid loop call#121
linrongbin16 merged 6 commits intomasterfrom
perf-add-placeholder-to-avoid-mis-using

Conversation

@linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented Nov 16, 2023

Regression Test

Platforms

  • windows
  • macOS
  • linux

Tasks

  • Use <leader>gl to copy git link.
  • Use <leader>gL to open git link in browser.
  • Copy git link in a symlink directory of git repo.
  • Copy git link in an un-pushed git branch, and receive an expected error.
  • Copy git link in a pushed git branch but edited file, and receive a warning says the git link could be wrong.

@linrongbin16 linrongbin16 changed the title perf(routers): add placeholder to avoid incorrect use perf(routers): add placeholder to avoid loop call Nov 16, 2023
@github-actions github-actions bot added the perf label Nov 16, 2023
@codecov
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (229f3b3) 81.49% compared to head (3e6fb18) 80.25%.

Files Patch % Lines
lua/gitlinker/routers.lua 62.50% 6 Missing ⚠️
lua/gitlinker.lua 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   81.49%   80.25%   -1.24%     
==========================================
  Files          12       12              
  Lines         805      795      -10     
==========================================
- Hits          656      638      -18     
- Misses        149      157       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linrongbin16 linrongbin16 merged commit e605210 into master Nov 16, 2023
@linrongbin16 linrongbin16 deleted the perf-add-placeholder-to-avoid-mis-using branch November 16, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant