Skip to content

perf(routers): always add 'plain=1' for github#156

Merged
linrongbin16 merged 8 commits intomasterfrom
perf-always-add-display-source
Nov 27, 2023
Merged

perf(routers): always add 'plain=1' for github#156
linrongbin16 merged 8 commits intomasterfrom
perf-always-add-display-source

Conversation

@linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented Nov 27, 2023

…down like rendering

Regression Test

Platforms

  • windows
  • macOS
  • linux

Hosts

Functions

  • Use GitLink to copy git link.
  • Use GitLink! to open git link in browser.
  • Use GitLink blame to copy the /blame git link.
  • Use GitLink! blame to open the /blame git link in browser.
  • Copy git link in a symlink directory of git repo.
  • Copy git link in an un-pushed git branch, and receive an expected error.
  • Copy git link in a pushed git branch but edited file, and receive a warning says the git link could be wrong.

@github-actions github-actions bot added the perf label Nov 27, 2023
@linrongbin16 linrongbin16 changed the title perf(routers): always use 'plain=1'('display=source') to disable mark… perf(routers): always use 'plain=1'('display=source') to disable markdowns rendering Nov 27, 2023
@linrongbin16 linrongbin16 changed the title perf(routers): always use 'plain=1'('display=source') to disable markdowns rendering perf(routers): always use 'plain=1' to disable markdowns rendering Nov 27, 2023
@linrongbin16 linrongbin16 changed the title perf(routers): always use 'plain=1' to disable markdowns rendering perf(routers): always use 'plain=1' to disable markdown like rendering Nov 27, 2023
@linrongbin16 linrongbin16 changed the title perf(routers): always use 'plain=1' to disable markdown like rendering perf(routers): always add 'plain=1' to disable markdown like rendering Nov 27, 2023
@linrongbin16 linrongbin16 changed the title perf(routers): always add 'plain=1' to disable markdown like rendering perf(routers): always add 'plain=1' for github Nov 27, 2023
@linrongbin16
Copy link
Owner Author

relate: #142

@codecov
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9315320) 75.49% compared to head (6c431e6) 78.81%.

Files Patch % Lines
lua/gitlinker/routers.lua 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   75.49%   78.81%   +3.32%     
==========================================
  Files          11       11              
  Lines         959      963       +4     
==========================================
+ Hits          724      759      +35     
+ Misses        235      204      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linrongbin16 linrongbin16 merged commit 0a8925f into master Nov 27, 2023
@linrongbin16 linrongbin16 deleted the perf-always-add-display-source branch November 27, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant