feat(remotes): use inputlist on multiple git remotes#267
feat(remotes): use inputlist on multiple git remotes#267linrongbin16 merged 11 commits intomasterfrom
inputlist on multiple git remotes#267Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
|
After some testing, I found the current code base cannot work with The whole workflow is running inside the async/coroutine framwork, so I also have to wrap the But the issue is the But on another hand, the |
vim.ui.select on multiple git remotesinputlist on multiple git remotes
lua/gitlinker/git.lua
Outdated
| end | ||
|
|
||
| if #remotes > 1 then | ||
| return _select_remotes(remotes) |
There was a problem hiding this comment.
hi @tvsfx , wonder if you are interested in reviewing this PR?
It allows user to select the remotes (only when) there're multiple git remotes and user doesn't provide the remote parameter. Then this plugin will popup a dialog to allow user to select a remote, instead of throwing an error message.
I had done some manual testings on my local machine to make sure it is working.
There was a problem hiding this comment.
Hey, guess I'm too late to review this by now... (I'd have to read up some more on coroutines in Lua to be able to say anything substantial about it regardless) Anyway, I like this idea! I still prefer using the upstream of the current branch if it is available, but I think I'll use this for cases where no upstream is available and multiple remotes are configured (e.g. when checking out tags or raw commits).
There was a problem hiding this comment.
Feedbacks are welcome!
Close #266 .
Test Platforms
Test Hosts
Test Functions
GitLink(!)to copy git link (or open in browser).GitLink(!) blameto copy the/blamelink (or open in browser).GitLink(!) default_branchto open the/main//masterlink in browser (or open in browser).GitLink(!) current_branchto open the current branch link in browser (or open in browser).