fix insights query test to poll same query instead of restarting

Separate start_query from get_query_results polling to avoid starting
a new query on each retry attempt.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: whummer

aws-proxy/tests/proxy/test_cloudwatch.py

@@ -578,30 +578,33 @@ def test_logs_readonly_insights_query(start_aws_proxy, cleanups):
         ],
     )
 
-    # start_query and get_query_results through local client (proxied)
-    # should work in read-only mode - use retry to wait for query completion
-    def _run_insights_query():
-        start_time = int((time.time() - 300) * 1000)  # 5 minutes ago
-        end_time = int((time.time() + 60) * 1000)  # 1 minute from now
+    # start_query through local client (proxied) - should work in read-only mode
+    start_time = int((time.time() - 300) * 1000)  # 5 minutes ago
+    end_time = int((time.time() + 60) * 1000)  # 1 minute from now
 
+    def _start_query():
         query_response = logs_client.start_query(
             logGroupName=log_group_name,
             startTime=start_time,
             endTime=end_time,
             queryString="fields @timestamp, @message | limit 10",
         )
-        query_id = query_response["queryId"]
-        assert query_id is not None
+        return query_response["queryId"]
 
-        # get_query_results - poll until complete
+    # Retry start_query in case log events aren't indexed yet
+    query_id = retry(_start_query, retries=10, sleep=3)
+    assert query_id is not None
+
+    # get_query_results through local client (proxied) - poll until complete
+    def _get_query_results():
         results = logs_client.get_query_results(queryId=query_id)
         if results["status"] not in ["Complete", "Failed", "Cancelled"]:
             raise AssertionError(f"Query not complete yet: {results['status']}")
         if results["status"] != "Complete" or len(results["results"]) < 1:
             raise AssertionError("Query completed but no results found yet")
         return results
 
-    results = retry(_run_insights_query, retries=30, sleep=2)
+    results = retry(_get_query_results, retries=30, sleep=2)
     assert results["status"] == "Complete"
     assert len(results["results"]) >= 1