Merge pull request #4 from loopj/test-action

Run target tests automatically

Author: loopj

.github/workflows/test.yml

@@ -0,0 +1,24 @@
+name: Run Tests
+
+on:
+  workflow_dispatch:
+  push:
+  pull_request:
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y cmake build-essential
+
+      - name: Build test suite
+        run: cmake -Bbuild -DJOYBUS_BACKEND_LOOPBACK=1 && cmake --build build
+
+      - name: Run tests
+        run: ctest --test-dir build --output-on-failure

src/backend/loopback/joybus.c

@@ -19,21 +19,24 @@ static int joybus_loopback_disable(struct joybus *bus)
 
 static void handle_command_response(const uint8_t *buffer, uint8_t result, void *user_data)
 {
-  struct joybus *bus = (struct joybus *)user_data;
+  if (response_buffer == NULL || result <= 0)
+    return;
 
-  // Our loopback "transfer" is just to copy all the bytes
+  // Copy the bytes provided by the target into the read buffer
   memcpy(response_buffer, buffer, result);
+  response_length = result;
 }
 
 static int joybus_loopback_transfer(struct joybus *bus, const uint8_t *write_buf, uint8_t write_len, uint8_t *read_buf,
                                     uint8_t read_len, joybus_transfer_cb_t callback, void *user_data)
 {
-  // Save the buffer to write the response to
+  // Save the buffer to write the response to, default to zero length
   response_buffer = read_buf;
+  response_length = 0;
 
   // Handle the command using the registered target
   for (int i = 1; i <= write_len; i++) {
-    int rc = joybus_target_byte_received(bus->target, write_buf, i, handle_command_response, NULL);
+    int rc = joybus_target_byte_received(bus->target, write_buf, i, handle_command_response, bus);
     if (rc == 0) {
       // No more bytes expected
       break;
@@ -45,7 +48,7 @@ static int joybus_loopback_transfer(struct joybus *bus, const uint8_t *write_buf
   }
 
   // Call the transfer complete callback
-  callback(bus, read_len, user_data);
+  callback(bus, response_length, user_data);
 
   return 0;
 }

src/target/gc_controller.c

@@ -345,6 +345,7 @@ void joybus_gc_controller_init(struct joybus_gc_controller *controller, uint16_t
   target->api                  = &gc_controller_api;
 
   // Set the initial controller ID
+  memset(controller->id, 0, sizeof(controller->id));
   joybus_id_set_type_flags(controller->id, type);
 
   // Set the initial origin

test/target/test_wavebird.c

@@ -27,13 +27,9 @@ void setUp(void)
   joybus_loopback_init(&bus);
   joybus_enable(&bus);
 
-  // Register a standard GameCube controller target
+  // Register a WaveBird receiver controller target
   joybus_gc_controller_init(&controller, JOYBUS_WAVEBIRD_RECEIVER);
   joybus_target_register(&bus, JOYBUS_TARGET(&controller));
-
-  // Reset response capture
-  response_len = -1;
-  memset(response, 0, sizeof(response));
 }
 
 void tearDown(void)