Add stacklevel to print appropriate location in warnings. (#1986)

* Add stacklevel to print appropriate location in warnings.

* Add to authors.

* Update changelog

Co-authored-by: Steven Loria <sloria1@gmail.com>

Author: tirkarthi

AUTHORS.rst

@@ -168,3 +168,4 @@ Contributors (chronological)
 - Ben Windsor `@bwindsor <https://github.com/bwindsor>`_
 - Kevin Kirsche `@kkirsche <https://github.com/kkirsche>`_
 - Isira Seneviratne `@Isira-Seneviratne <https://github.com/Isira-Seneviratne>`_
+- Karthikeyan Singaravelan `@tirkarthi  <https://github.com/tirkarthi>`_

CHANGELOG.rst

@@ -13,6 +13,8 @@ Other changes:
 
 - Set lower bound for `packaging` requirement (:issue:`1957`).
   Thanks :user:`MatthewNicolTR` for reporting and thanks :user:`sirosen` for the PR.
+- Improve warning messages by passing `stacklevel` (:pr:`1986`).
+  Thanks :user:`tirkarthi` for the PR.
 
 3.15.0 (2022-03-12)
 *******************

src/marshmallow/fields.py

@@ -174,6 +174,7 @@ def __init__(
                 "The 'default' argument to fields is deprecated. "
                 "Use 'dump_default' instead.",
                 RemovedInMarshmallow4Warning,
+                stacklevel=2,
             )
             if dump_default is missing_:
                 dump_default = default
@@ -182,6 +183,7 @@ def __init__(
                 "The 'missing' argument to fields is deprecated. "
                 "Use 'load_default' instead.",
                 RemovedInMarshmallow4Warning,
+                stacklevel=2,
             )
             if load_default is missing_:
                 load_default = missing
@@ -220,6 +222,7 @@ def __init__(
                 "explicit `metadata=...` argument instead. "
                 f"Additional metadata: {additional_metadata}",
                 RemovedInMarshmallow4Warning,
+                stacklevel=2,
             )
 
         self._creation_index = Field._creation_index
@@ -298,6 +301,7 @@ def fail(self, key: str, **kwargs):
                 key
             ),
             RemovedInMarshmallow4Warning,
+            stacklevel=2,
         )
         raise self.make_error(key=key, **kwargs)
 
@@ -439,6 +443,7 @@ def default(self):
             "The 'default' attribute of fields is deprecated. "
             "Use 'dump_default' instead.",
             RemovedInMarshmallow4Warning,
+            stacklevel=2,
         )
         return self.dump_default
 
@@ -448,6 +453,7 @@ def default(self, value):
             "The 'default' attribute of fields is deprecated. "
             "Use 'dump_default' instead.",
             RemovedInMarshmallow4Warning,
+            stacklevel=2,
         )
         self.dump_default = value
 
@@ -457,6 +463,7 @@ def missing(self):
             "The 'missing' attribute of fields is deprecated. "
             "Use 'load_default' instead.",
             RemovedInMarshmallow4Warning,
+            stacklevel=2,
         )
         return self.load_default
 
@@ -466,6 +473,7 @@ def missing(self, value):
             "The 'missing' attribute of fields is deprecated. "
             "Use 'load_default' instead.",
             RemovedInMarshmallow4Warning,
+            stacklevel=2,
         )
         self.load_default = value
 
@@ -550,6 +558,7 @@ def __init__(
                 "Passing 'self' to `Nested` is deprecated. "
                 "Use `Nested(lambda: MySchema(...))` instead.",
                 RemovedInMarshmallow4Warning,
+                stacklevel=2,
             )
         self.nested = nested
         self.only = only

src/marshmallow/utils.py

@@ -84,6 +84,7 @@ def pprint(obj, *args, **kwargs) -> None:
     warnings.warn(
         "marshmallow's pprint function is deprecated and will be removed in marshmallow 4.",
         RemovedInMarshmallow4Warning,
+        stacklevel=2,
     )
     if isinstance(obj, collections.OrderedDict):
         print(json.dumps(obj, *args, **kwargs))