Merge pull request #130 from massiveart/enhancement/command-default-name

Add command default names

Author: danrot

CHANGELOG.md

@@ -1,6 +1,9 @@
 CHANGELOG
 =========
 
+* 0.17.3 (2019-08-22)
+    * ENHANCEMENT  #130 Add command default names
+
 * 0.17.2 (2019-08-20)
     * ENHANCEMENT  #129 Added dispatching of pre-deindex event
     * ENHANCEMENT  #127 Custom repository method bugfix

Command/IndexRebuildCommand.php

@@ -20,13 +20,13 @@
  */
 class IndexRebuildCommand extends ReindexCommand
 {
-    /**
-     * {@inheritdoc}
-     */
+    protected static $defaultName = 'massive:search:index:rebuild';
+
     public function configure()
     {
         parent::configure();
-        $this->setName('massive:search:index:rebuild');
+
+        $this->setName(self::$defaultName);
     }
 
     /**

Command/InitCommand.php

@@ -21,20 +21,22 @@
  */
 class InitCommand extends Command
 {
+    protected static $defaultName = 'massive:search:init';
+
     /**
      * @var AdapterInterface
      */
     private $adapter;
 
     public function __construct(AdapterInterface $adapter)
     {
-        parent::__construct();
+        parent::__construct(self::$defaultName);
+
         $this->adapter = $adapter;
     }
 
     public function configure()
     {
-        $this->setName('massive:search:init');
         $this->setDescription('Initializes the search bundle');
         $this->setHelp('This command will simply call the initialize method of the currently active search adapter.');
     }

Command/PurgeCommand.php

@@ -24,6 +24,8 @@
  */
 class PurgeCommand extends Command
 {
+    protected static $defaultName = 'massive:search:purge';
+
     /**
      * @var SearchManagerInterface
      */
@@ -38,14 +40,14 @@ public function __construct(
         SearchManagerInterface $searchManager,
         QuestionHelper $questionHelper = null
     ) {
-        parent::__construct();
+        parent::__construct(self::$defaultName);
+
         $this->searchManager = $searchManager;
         $this->questionHelper = $questionHelper ?: new QuestionHelper();
     }
 
     public function configure()
     {
-        $this->setName('massive:search:purge');
         $this->setDescription('Purge one, many or all indexes.');
         $this->setHelp(<<<'EOT'
 Purge one, many or all indexes:

Command/QueryCommand.php

@@ -24,15 +24,17 @@
  */
 class QueryCommand extends Command
 {
+    protected static $defaultName = 'massive:search:query';
+
     /**
      * @var SearchManagerInterface
      */
     private $searchManager;
 
-    public function __construct(
-        SearchManagerInterface $searchManager
-    ) {
-        parent::__construct();
+    public function __construct(SearchManagerInterface $searchManager)
+    {
+        parent::__construct(self::$defaultName);
+
         $this->searchManager = $searchManager;
     }
 
@@ -41,12 +43,12 @@ public function __construct(
      */
     public function configure()
     {
-        $this->setName('massive:search:query');
         $this->addArgument('query', InputArgument::REQUIRED, 'Search query');
         $this->addOption('index', 'I', InputOption::VALUE_IS_ARRAY | InputOption::VALUE_REQUIRED, 'Index to search');
         $this->addOption('locale', 'l', InputOption::VALUE_REQUIRED, 'Index to search');
         $this->setDescription('Search the using a given query');
-        $this->setHelp(<<<'EOT'
+        $this->setHelp(
+            <<<'EOT'
 The %command.name_full% command will search the configured repository and present
 the results.
 
@@ -72,15 +74,17 @@ public function execute(InputInterface $input, OutputInterface $output)
         $table->setHeaders(['Score', 'ID', 'Title', 'Description', 'Url', 'Image', 'Class']);
         foreach ($hits as $hit) {
             $document = $hit->getDocument();
-            $table->addRow([
-                $hit->getScore(),
-                $document->getId(),
-                $document->getTitle(),
-                $this->truncate($document->getDescription(), 50),
-                $document->getUrl(),
-                $document->getImageUrl(),
-                $document->getClass(),
-            ]);
+            $table->addRow(
+                [
+                    $hit->getScore(),
+                    $document->getId(),
+                    $document->getTitle(),
+                    $this->truncate($document->getDescription(), 50),
+                    $document->getUrl(),
+                    $document->getImageUrl(),
+                    $document->getClass(),
+                ]
+            );
         }
         $table->render();
         $output->writeln(sprintf('%s result(s) in %fs', count($hits), $timeElapsed));

Command/ReindexCommand.php

@@ -32,6 +32,8 @@
  */
 class ReindexCommand extends Command
 {
+    protected static $defaultName = 'massive:search:reindex';
+
     /**
      * @var string
      */
@@ -64,7 +66,8 @@ public function __construct(
         $env,
         QuestionHelper $questionHelper = null
     ) {
-        parent::__construct();
+        parent::__construct(self::$defaultName);
+
         $this->resumeManager = $resumeManager;
         $this->searchManager = $searchManager;
         $this->providerRegistry = $providerRegistry;
@@ -77,7 +80,6 @@ public function __construct(
      */
     public function configure()
     {
-        $this->setName('massive:search:reindex');
         $this->setDescription('Rebuild search index');
         $this->setHelp(<<<'EOT'
 This command will launch an event will trigger the search index to be rebuilt

Command/StatusCommand.php

@@ -13,7 +13,7 @@
 
 use Massive\Bundle\SearchBundle\Search\SearchManager;
 use Massive\Bundle\SearchBundle\Search\SearchManagerInterface;
-use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
+use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -22,22 +22,24 @@
  * This command returns some vendor specific information about
  * the currently configured search implementation.
  */
-class StatusCommand extends ContainerAwareCommand
+class StatusCommand extends Command
 {
+    protected static $defaultName = 'massive:search:status';
+
     /**
      * @var SearchManager
      */
     private $searchManager;
 
     public function __construct(SearchManagerInterface $searchManager)
     {
-        parent::__construct();
+        parent::__construct(self::$defaultName);
+
         $this->searchManager = $searchManager;
     }
 
     public function configure()
     {
-        $this->setName('massive:search:status');
         $this->setDescription('Return the status of the configured search engine');
         $this->setHelp(<<<'EOT'
 Return detailed information about the current search implementation