[Feat] Model Manager (MM) Attempt 3 #1457
Conversation
- added the SkipJsonSchema - added the dynamic type generation, but not yet using it
for more information, see https://pre-commit.ci
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2025-10-31 09:54:20 UTC Compare the examples using the commit's wheel file vs the latest released version: vizro-core/examples/scratch_devView with commit's wheel vs View with latest release vizro-core/examples/dev/View with commit's wheel vs View with latest release vizro-core/examples/visual-vocabulary/View with commit's wheel vs View with latest release vizro-core/examples/tutorial/ |
Added better test cases
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…definitions. Update tests to validate behavior of custom components in discriminated unions, including cases without explicit type definitions.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
|
||
| if __name__ == "__main__": | ||
| """ | ||
| TODOs Maxi: |
There was a problem hiding this comment.
This is the main ToDo list
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
In this folder I constructed fake Vizro. The place of it will of course change, but it was easiest to have it in a realistic place for now.
All the issues I encountered (except for the very last one) I built in here, and I wrote tests for them. These tests are not 100% covering, but they were always written to catch a specific problem
There was a problem hiding this comment.
This is where the tests for fake Vizro lie
| - serialization/deserialization - DONE | ||
| - NEW: circular deps issue (see below) - DONE | ||
| - custom components do not end up in the tree - DONE | ||
| - CURRENT ISSUE: containers in tabs seem to cause problems - need to investigate |
There was a problem hiding this comment.
This is the issue where I stopped - you can run the normal dev example where I commented out everything out to isolate the issue. For this I have not yet written tests and it is not yet in fake Vizro
| Field(default={}, description="Mapping from name of a pages group to a list of page IDs/titles."), | ||
| ] | ||
|
|
||
| # @_log_call |
There was a problem hiding this comment.
This is one of the many examples where I am changing things in main Vizro temporarily to make things work. Here we simply do not validate pages anymore which needs to be worked out properly, but for the time being it was easier just to comment it out. This sort of thing was done a few times throughout the codebase.
For this specific issue I had already worked out things regarding Navigation stuff, and pre-build order in the very first MM attempt, but we abandoned it for other reasons.
That PR is not the easiest to read anymore because there is lots of unrelated things now merged in, but it does contain useful information about some thoughts about pre-build orders etc. Probably best as some inspiration etc. The PR description is particularly useful describing some of the intuition
Description
Closes https://github.com/McK-Internal/vizro-internal/issues/2273
So far mainly a construction of a Fake Vizro along with proper test suit that checks for all problems present.
See comment for ToDos
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":