Skip to content

feat: support adding items to any slot in containers#1033

Merged
Nottinghster merged 1 commit intomainfrom
support-adding-to-slot
Jan 13, 2025
Merged

feat: support adding items to any slot in containers#1033
Nottinghster merged 1 commit intomainfrom
support-adding-to-slot

Conversation

@nekiro
Copy link
Copy Markdown
Contributor

@nekiro nekiro commented Jan 12, 2025

Description

Right now the code either adds to first or last slot, with this change we can add to any slot. I needed this behaviour for custom ordered backpacks. Servers (based on tfs) send 0 always and pageEnd (max slot) for paginated containers, so this change should be safe to do.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@sonarqubecloud
Copy link
Copy Markdown

@Nottinghster Nottinghster merged commit aa2022e into main Jan 13, 2025
@nekiro nekiro deleted the support-adding-to-slot branch January 13, 2025 18:26
vllsystems pushed a commit to vllsystems/otclient that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants