Skip to content

fix: mobile detection when compiling for macOS#1065

Merged
mehah merged 1 commit intoopentibiabr:mainfrom
eduardojunio:fix_mobile_detection_on_mac
Jan 22, 2025
Merged

fix: mobile detection when compiling for macOS#1065
mehah merged 1 commit intoopentibiabr:mainfrom
eduardojunio:fix_mobile_detection_on_mac

Conversation

@eduardojunio
Copy link
Contributor

@eduardojunio eduardojunio commented Jan 22, 2025

Description

Previously the mobile detection code was not working properly. It was detecting macOS as a mobile platform. This PR fixes it.

Behavior

Actual

When compiling for macOS and running the client it was showing a joystick and other UI artifacts designed for a mobile platform like Android or iOS.

Expected

When compiling for macOS it should behave as a desktop platform.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I've compiled it after the change and the joystick and other mobile UI artifacts were gone. The client was behaving as expected.
  • I wasn't able to test builds in other platforms like Android or Windows, but given the very small change I'm not expecting any issues.

Test Configuration:

  • Server Version: 11.00
  • Client: latest master commit
  • Operating System: macOS 15.2

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Previously the mobile detection code was not working properly. It was
detecting macOS as a mobile platform. This commit fixes it.
@sonarqubecloud
Copy link

@eduardojunio eduardojunio marked this pull request as ready for review January 22, 2025 03:16
@eduardojunio
Copy link
Contributor Author

@luanluciano93 thank you for reviewing this! Could you please merge it? Thanks!

@mehah mehah changed the title Fix mobile detection when compiling for macOS fix: mobile detection when compiling for macOS Jan 22, 2025
@mehah mehah merged commit e3ce723 into opentibiabr:main Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants