feat: load sounds with protobuf#1074
Merged
mehah merged 11 commits intoopentibiabr:mainfrom Jan 28, 2025
Merged
Conversation
Contributor
Author
|
reviews are welcome at every stage of this PR! |
kokekanon
reviewed
Jan 24, 2025
Contributor
|
versions that do not use protobuf this error is displayed maybe |
Contributor
Author
|
any more changes needed? |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This is a continuation of bringing expanded protobuf support to otclient.
This isn't a complete solution but moves us very close to forwarding protobuf soundbanks to the client
These things are "to do", that won't be part of this PR:
Type of change
(note on "breaking" checkbox: current sound files will be moved to another place as data/sounds will work like data/things when I finish this PR)
How Has This Been Tested
(requires "enable audio" option checked)
terminal:
g_sounds.play('/sounds/1320/' .. g_sounds.getAudioFileNameById(4))Checklist