Skip to content

improve: add macOS CMake presets#1083

Merged
mehah merged 1 commit intoopentibiabr:mainfrom
eduardojunio:add_macos_preset
Jan 27, 2025
Merged

improve: add macOS CMake presets#1083
mehah merged 1 commit intoopentibiabr:mainfrom
eduardojunio:add_macos_preset

Conversation

@eduardojunio
Copy link
Copy Markdown
Contributor

@eduardojunio eduardojunio commented Jan 25, 2025

Description

This should easy the build process on macOS by providing a set of presets that can be used to build the project with a single command.

The release preset sets the compiler optimization level to O1 because O2 and above crashes the client when starting up.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

  • I've tested both configurations on Apple Silicon Macs and it seems stable.

Test Configuration:

  • Server Version: 11.00
  • Client: 11.00
  • Operating System: macOS 15.2

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

This should easy the build process on macOS by providing a set of
presets that can be used to build the project with a single command.

The release preset sets the compiler optimization level to O1 because
O2 and above crashes the client when starting up.
@eduardojunio eduardojunio marked this pull request as ready for review January 25, 2025 03:48
@sonarqubecloud
Copy link
Copy Markdown

@mehah mehah changed the title Add macOS CMake presets improve: add macOS CMake presets Jan 27, 2025
@mehah mehah merged commit 2a0c2a1 into opentibiabr:main Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants