Skip to content

feat: cyclopedia back button#1115

Merged
mehah merged 7 commits intoopentibiabr:mainfrom
bdzicc:cyclopedia-back-button
Mar 14, 2025
Merged

feat: cyclopedia back button#1115
mehah merged 7 commits intoopentibiabr:mainfrom
bdzicc:cyclopedia-back-button

Conversation

@bdzicc
Copy link
Copy Markdown
Contributor

@bdzicc bdzicc commented Mar 10, 2025

Description

Added logic for cyclopedia back button to cycle through previous tab history
image

Behavior

Actual

Currently back button does nothing

Expected

Back button should iterate through tab history LIFO

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Click through various tabs to add to stack and then use back button to cycle through history

Test Configuration:

  • Server Version: Canary 13.40
  • Client: OTC Redemption
  • Operating System: Windows 10

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@sonarqubecloud
Copy link
Copy Markdown

@bdzicc
Copy link
Copy Markdown
Contributor Author

bdzicc commented Mar 12, 2025

I made a couple more changes I realized when testing this some more. The toggle() function was always selecting the 'items' tab and then a SelectWindow() call was being made for the bosstiary and boss slots buttons. This was pushing 'items' onto the back button history stack even though it was never selected.

Also cleared the back button history when the cyclopedia is closed so it doesn't persist when reopened. This is how it works on RT.

@mehah mehah requested a review from kokekanon March 13, 2025 19:59
@mehah
Copy link
Copy Markdown
Collaborator

mehah commented Mar 13, 2025

is done @bdzicc ?

@bdzicc
Copy link
Copy Markdown
Contributor Author

bdzicc commented Mar 13, 2025

Yes, all set @mehah

@mehah mehah merged commit 5bf0e87 into opentibiabr:main Mar 14, 2025
12 checks passed
vllsystems pushed a commit to vllsystems/otclient that referenced this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants