Skip to content

fix: Icon updates and equipping items via the actionbar#1119

Merged
mehah merged 12 commits intoopentibiabr:mainfrom
andreoam:otclient-mehar-para-criar-prs
Mar 18, 2025
Merged

fix: Icon updates and equipping items via the actionbar#1119
mehah merged 12 commits intoopentibiabr:mainfrom
andreoam:otclient-mehar-para-criar-prs

Conversation

@andreoam
Copy link
Copy Markdown
Contributor

@andreoam andreoam commented Mar 16, 2025

Description

  • Updated icons

  • Fixed the borders of rare icons when vbot is active

  • Updated action bar
    Now the actionbar equips items, inside closed backpacks. Ideal for SSA macros or quick equipping with hotkeys

  • Updated the open gamestore button in the prey window

Before

before.mp4

After

after.mp4

@andreoam andreoam changed the title Otclient mehar para criar prs Atualizações de Icones e Equipar item pela actionbar Mar 16, 2025
modules.game_hotkeys.executeHotkeyItem(HOTKEY_USEONSELF, slot.itemId, slot.subType)
elseif slot.useType == 'equip' then
local item = g_game.findPlayerItem(slot.itemId, -1, slot.getTier)
local item = Item.create(slot.itemId)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why create instead getting from player?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obter do player so estava equipando os itens em backpacks abertas, Utilizei a mesma logica do otcv8

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English please

Copy link
Copy Markdown
Contributor

@Vysius Vysius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont really get the changes in actionbar. Someone else review too

@kokekanon
Copy link
Copy Markdown
Contributor

modify the description in English , so that we all understand , and modify the title with the prefix "fix:"

@kokekanon
Copy link
Copy Markdown
Contributor

kokekanon commented Mar 16, 2025

in modules /game_prey/prey.otui there are several calls to modules.game_shop.show()

should be @onClick: modules.game_mainpanel.toggleStore()

image

@andreoam andreoam changed the title Atualizações de Icones e Equipar item pela actionbar [Fix] Icon updates and equipping items via the actionbar Mar 16, 2025
@andreoam
Copy link
Copy Markdown
Contributor Author

updated suggestions

added video of actionbar functionality

@mehah mehah changed the title [Fix] Icon updates and equipping items via the actionbar fix: Icon updates and equipping items via the actionbar Mar 16, 2025
@kokekanon
Copy link
Copy Markdown
Contributor

kokekanon commented Mar 16, 2025

updated suggestions

added video of actionbar functionality

try with 2 equal items with tier and without tier

this fix that :
image

@andreoam
Copy link
Copy Markdown
Contributor Author

sugestões atualizadas
adicionado vídeo da funcionalidade da barra de ação

tente com 2 itens iguais com nível e sem nível

esta correção que: imagem

what does it do?

@kokekanon
Copy link
Copy Markdown
Contributor

kokekanon commented Mar 16, 2025

what does it do?

I see you use canary

/i 3388,1
/i 3388,1,5
add action bar

image

when you click to equip...
currently difference between item tier ? no

@andreoam
Copy link
Copy Markdown
Contributor Author

andreoam commented Mar 16, 2025

o que ele faz?

Vejo que você usa canário

/i 3388,1 /i 3388,1,5 adicionar barra de ação

imagem

quando você clica para equipar... atualmente diferença entre o nível do item? não

okay

updated

@andreoam andreoam requested review from Vysius and kokekanon March 16, 2025 20:07
function getPanelActionbar()
return actionBar
end
end No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
end
end

Adicionado ícone igual cliente cip com link direto para gamestore
update prey.otui
add constant GameColorizedLootValue
added setTier to luafunctions.cpp and updated game_actionbar.lua to use setTier
fix: equip action bar item with closed backpack
@andreoam andreoam requested a review from kokekanon March 17, 2025 01:52
andreoam and others added 2 commits March 16, 2025 22:53
Co-authored-by: kokekanon <114332266+kokekanon@users.noreply.github.com>
Co-authored-by: kokekanon <114332266+kokekanon@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

@kokekanon kokekanon removed the request for review from Vysius March 17, 2025 20:17
@mehah mehah merged commit 245ff3c into opentibiabr:main Mar 18, 2025
12 checks passed
vllsystems pushed a commit to vllsystems/otclient that referenced this pull request Mar 19, 2025
@andreoam andreoam deleted the otclient-mehar-para-criar-prs branch May 26, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants