feat: version 14 by murilo09 · Pull Request #1173 · opentibiabr/otclient

murilo09 · 2025-05-26T05:37:10Z

Description

Support to version 14+

Missing UI/Module from 14.12 charms window

Type of change

Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I checked the PR checks reports
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works

Co-Authored-By: Eduardo Dantas eduardo.dantas@hotmail.com.br

Can use: std::string message = "Testing fmt::format"; g_logger.info("{}", message)

src/framework/net/inputmessage.h

src/framework/net/outputmessage.h

src/framework/net/protocol.cpp

kokekanon · 2025-05-26T06:33:32Z

init.lua


--[[
+
 Servers_init = {


This table Servers_init must be deactivated before being merged into the main repo

This table Servers_init must be deactivated before being merged into the main repo

Yes, we will revert when everything is ok, this makes it easier to test.

kokekanon · 2025-05-26T06:36:03Z

src/framework/net/protocol.cpp

 #include "inputmessage.h"
 #include "outputmessage.h"
 #include "framework/core/graphicalapplication.h"
+#include "client/game.h"


I think
This implementation could be achieved without including #include "client/game.h".

A new enum GameFeature should be created in const.h, and also defined in gamelib/const.lua. To activate it, it must be enabled in game_feature and then activated in gamelib/protocollogin.lua

example:
m_xteaEncryptionEnabled , m_checksumEnabled , m_sequencedPackets change the boolean from lua
https://github.com/mehah/otclient/blob/085a7876ba8164cb8eb08385812b12ceeec007aa/modules/gamelib/protocollogin.lua#L135-L148

in order to be able to login in protocol 11.00 in canary 14.xx

kokekanon · 2025-05-26T08:03:03Z

if anyone has fmt error

1> vc17\vcpkg_installed\x64-windows-static\include\fmt\base.h(458,28): error C2338: static_assert failed: 'Unicode support requires compiling with /utf-8'
1>(compiling source file 'otclient/x64/OpenGL/unity_QAHRA73EM9MJH98D.cpp')

add https://github.com/mehah/otclient/blob/main/vc17/otclient.vcxproj#L261-L262

 <AdditionalOptions>/utf-8 %(AdditionalOptions)</AdditionalOptions>

in vc17otclient.vcxproj

me test:

test		note
8.6	❌
13.40	❌
14.05 canary main repo	✅
14.12 canary pr	✅	+ otcr pr # 1171
15.00 public server	✅	+ otcr pr # 1172

…version This commit removes the hardcoded MAX_HEADER_SIZE constant from OutputMessage and replaces it with a dynamically initialized m_maxHeaderSize based on the client version (7 for >= 1405, otherwise 8), similar to InputMessage. All references to MAX_HEADER_SIZE have been removed, and buffer positions (m_writePos, m_headerPos) are now initialized based on m_maxHeaderSize. This ensures consistency and future-proofing for different protocol versions that require varying header sizes.

dudantas · 2025-06-08T18:06:30Z

if anyone has fmt error
1> vc17\vcpkg_installed\x64-windows-static\include\fmt\base.h(458,28): error C2338: static_assert failed: 'Unicode support requires compiling with /utf-8'
1>(compiling source file 'otclient/x64/OpenGL/unity_QAHRA73EM9MJH98D.cpp')
add https://github.com/mehah/otclient/blob/main/vc17/otclient.vcxproj#L261-L262
 <AdditionalOptions>/utf-8 %(AdditionalOptions)</AdditionalOptions>
in vc17otclient.vcxproj

me test:

test note
8.6 ❌
13.40 ❌
14.05 canary main repo ✅
14.12 canary pr ✅ + otcr pr # 1171
15.00 public server ✅ + otcr pr # 1172

13.14 was already broken before, from what I saw, I'll try to fix it

About the build solution, I always use cmake, even in visual studio, so I hadn't noticed that it broke the solution, I have an open pr to add a workflow in gha to build windows with solution, thus avoiding future problems like this. Thanks

javiertringol

What's missing for this to be approved? It's been 37 days since Canary approved 14.05
and 2 weeks since 14.12

What's missing? How can the community help?

sonarqubecloud · 2025-06-22T23:26:18Z

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vllsystems

I'm using this since 13/06 and no crashs, no kicks, no breaks.

Sounds good to me.

bateunatrave

tested for a long time without problems.

dudantas · 2025-07-28T18:09:04Z

What's missing for this to be approved? It's been 37 days since Canary approved 14.05 and 2 weeks since 14.12

What's missing? How can the community help?

The 14.12 charms window (which has been completely changed) needs to be tested and fixed.

From the comments here, it's clear that it wasn't properly tested. If it had been tested, you would have seen that the charms window doesn't work. If anyone has UI/module knowledge, they can do this so we can merge it.

javiertringol · 2025-07-28T18:25:52Z

I'm happy just being able to login.

Also, many times we have to use the cipsoft client — like with the Wheel or Forge — and then go back to the OTC client. I guess it'll be the same with Charms.

kokekanon · 2025-07-28T18:35:47Z

I've had it done for a while in PR #1171. I made sure not to break backward compatibility.

i create two UI (.otui)

< 1340

> 14.10

At that time, I was just missing information on where to get the charm data from version 14.00, since it's not retrieved from the proto or server.
I'll try to finish it today.

FelipePaluco · 2025-07-28T19:16:55Z

@kokekanon if you want, here is a example of the latest image from Cipsoft.

And yes, those informations like description do not come from proto or server (they're hardcoded on client-side, like the magical archive is). If you need more support regarding the image extraction, tell me. I can help you.

kokekanon · 2025-07-28T23:49:10Z

@kokekanon if you want, here is a example of the latest image from Cipsoft.

i don't use canary, quick test works

I have to check if I broke something in 13.40

I don't like modifying PRs that aren't mine, especially if I don't have the author's permission.

I'll reopen my PR, take the 14.00 header fix, and merge it with the features and packets I already have there.
That way, it's more likely to get approved quickly for compatibility with the main Canary repo (14.12)

FelipePaluco · 2025-07-28T23:51:23Z

@kokekanon looks great! If you want, commit in the same branch. Then we can adjust anything if necessary.

lmiguelm24 · 2025-07-28T23:59:43Z

Si alguien tiene fmt error
1> vc17\vcpkg_installed\x64-windows-static\include\fmt\base.h(458,28): error C2338: static_assert failed: 'Unicode support requires compiling with /utf-8'
1>(compiling source file 'otclient/x64/OpenGL/unity_QAHRA73EM9MJH98D.cpp')
agregue https://github.com/mehah/otclient/blob/main/vc17/otclient.vcxproj#L261-L262
 <AdditionalOptions>/utf-8 %(AdditionalOptions)</AdditionalOptions>
en vc17otclient.vcxproj

mi prueba:

prueba nota
8.6 ❌
13.40 ❌
Repositorio principal de Canary 14.05 ✅
14.12 pr canario ✅ + otro pr # 1171
15.00 servidor público ✅ + otro pr # 1172

With these exchange rates does it work out at 15.00?

luanluciano93 · 2025-07-30T18:16:22Z

this PR is being closed for PR merge #1171 1171

dudantas and others added 8 commits April 21, 2025 10:23

init: 14.05 support

69799e1

fix: protocol 14

cdab8f4

fix login 14

badd8a9

send appearances hash

29e9477

improve: add support to fmt format to logger class

35f8610

Can use: std::string message = "Testing fmt::format"; g_logger.info("{}", message)

fix: vs warnings

8df8177

fix: final 14.12 support

9574a08

Merge branch 'main' into dudantas/version-1405

d05170b

murilo09 mentioned this pull request May 26, 2025

feat: protocol 14.00 ~ 14.12 packets and features #1171

Merged

19 tasks