improve: GameLoadSprInsteadProtobuf

[kokekanon]

Description

with this you can enter 13.40 without packets error in mode : .dat and .spr

you will need these 3 files in data/things/1340/

1. tibia.spr
2. tibia.dat
   is obtained from here
   https://downloads.ots.me/?dir=data/tibia-clients/dat_and_spr
   
   or of assets editor
   https://github.com/Arch-Mina/Assets-Editor
3. appearances.dat is obtained from here
   https://github.com/opentibiabr/canary/tree/main/data/items
   or of assets editor
   https://github.com/Arch-Mina/Assets-Editor
4. g_game.enableFeature(GameLoadSprInsteadProtobuf) in game_feature

---

about this bool function

ThingTypeManager::loadAppearances(const std::string& file)
I just added an if
if (!g_game.getFeature(Otc::GameLoadSprInsteadProtobuf)) {

Behavior

Actual

packets error because of flag item

Expected

no packets error

Fixes

none

Type of change

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

• Test A: 13.40 with assets
• Test B: 13.40 with .dat and .spr

Test Configuration:

• Server Version: 13.40
• Client: 13.40
• Operating System: win 10

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud