Skip to content

fix: properly animate items in outfits#1241

Merged
mehah merged 1 commit intomainfrom
fix-animation-on-creatures
Jul 19, 2025
Merged

fix: properly animate items in outfits#1241
mehah merged 1 commit intomainfrom
fix-animation-on-creatures

Conversation

@nekiro
Copy link
Copy Markdown
Contributor

@nekiro nekiro commented Jul 19, 2025

Description

Fix improperly animated item looktypes

Behavior

Actual

Item type outfits are animating too slow/fast depending on the item ticks per frame config option and ignores the timings set in .dat.

Expected

Should respect and properly animate taking into consideration dat timings.
Good example of this is bath tub store item from cip tibia.

Fixes

Probably fix #1077

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@sonarqubecloud
Copy link
Copy Markdown

@Cwiras
Copy link
Copy Markdown

Cwiras commented Jul 19, 2025

Accepted.

@mehah mehah merged commit 0faf8b9 into main Jul 19, 2025
13 checks passed
@mehah mehah deleted the fix-animation-on-creatures branch July 19, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lookItem animation is playing too fast

3 participants