Skip to content

fix: "clear messages" functionality with readonly mode (like tibia rl)#1268

Merged
mehah merged 1 commit intomainfrom
Nottinghster-patch-1
Aug 4, 2025
Merged

fix: "clear messages" functionality with readonly mode (like tibia rl)#1268
mehah merged 1 commit intomainfrom
Nottinghster-patch-1

Conversation

@Nottinghster
Copy link
Copy Markdown
Contributor

Description

Fixes the behavior of the "Clear Messages" function when a tab is in readonly mode. Previously, when clearing messages from the original tab, messages from the corresponding readonly tab were not being cleared.

Changes

  • Modified the clearChannel function to check if the tab being cleared is in readonly mode
  • Fixed the element ID in the readonly panel (from 'readOnlyBuffer' to 'panel')
  • Simplified the verification logic to ensure consistency between original and readonly tabs

Behavior

  • When clearing messages from original tab: also clears the corresponding readonly tab (if it exists)
  • When clearing messages from readonly tab: also clears the corresponding original tab

Impact

This fix improves user experience by maintaining synchronization between original and readonly tabs when messages are cleared.

Testing Performed

  • Tested clearing behavior on original tab
  • Tested clearing behavior on readonly tab
  • Verified synchronization between tabs in both cases

Video

OTClient.-.Redemption.LIVE.RELOAD.ENABLED.2025-08-03.20-06-32.mp4

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 3, 2025

@mehah mehah merged commit 65c481b into main Aug 4, 2025
4 checks passed
@mehah mehah deleted the Nottinghster-patch-1 branch August 4, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants