Skip to content

feat: prey creatures html#1380

Draft
gabrielew wants to merge 47 commits intoopentibiabr:mainfrom
gabrielew:feat/prey_creatures_html
Draft

feat: prey creatures html#1380
gabrielew wants to merge 47 commits intoopentibiabr:mainfrom
gabrielew:feat/prey_creatures_html

Conversation

@gabrielew
Copy link
Contributor

@gabrielew gabrielew commented Oct 17, 2025

Description

Migrating the Prey window from OTUI to HTML

Summary

  • Infinite scroll / lazy loading for the prey selection list to handle large datasets without freezing the UI.
  • Prevent full UI reload after confirmation; only the affected parts update.
  • Reset prey slot state when the slot type changes to avoid stale state leakage.
  • Hide the active monster from the selectable names list to avoid duplicate/invalid choices.
  • Improve resource validation across events; update resource bindings where needed.
  • Layout / color tweaks to keep visual consistency and readability.

Behavior

Actual

image image image image image image
2025-10-17.15-17-09.mp4

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas

mehah and others added 30 commits October 14, 2025 15:47
@mehah
layout flex
b6f5b3d
@mehah
fixes
a9fc4e0
@mehah
layout_flex to uilayoutflexbox
a3132fc
@gabrielew
Merge branch 'main' of github.com:gabrielew/otclient into flex_box
9f37a0f
@gabrielew
feat: assets
e4b6c40
@gabrielew
refactor: change folder name
cf1b17f
@gabrielew
wip: prey
a964cb0
@gabrielew
fix: func name
127e184
@gabrielew
Merge branch 'main' of github.com:gabrielew/otclient into feat/prey_c…
6800594 
…reatures_html
@gabrielew
merge main
e1771af
@gabrielew
wip: layout
c1aad5c
@gabrielew
feat: choose monster
cb8608a
@gabrielew
feat: label colors
c460bf8
@gabrielew
feat: list reroll
10ff8f3
@gabrielew
fix: progress bart
96a63b1
@gabrielew
feat: layout
1e2155a
@gabrielew
Merge branch 'main' of github.com:gabrielew/otclient into feat/prey_c…
0414f4e 
…reatures_html
@gabrielew
Merge branch 'main' of github.com:gabrielew/otclient into feat/prey_c…
7ee65d7 
…reatures_html
@gabrielew
Merge branch 'main' of github.com:gabrielew/otclient into feat/prey_c…
beb7dea 
…reatures_html
@gabrielew
wip: layout
13deb1c
@gabrielew
feat: layout and on hover
4cd5aa1
@gabrielew
refactor: use registerEvents
1ef4f01
@gabrielew
Implement lazy loading for prey selection list
3617774
@gabrielew
Merge pull request #108 from gabrielew/2025-10-17/implement-infinite-…
84d7de3 
…scroll-for-prey-list

Implement lazy loading for prey list selection
@gabrielew
refactor: remove unnecessary param
d9dcbe4 
fix: select by index not type id
@gabrielew
Stop reloading prey UI after confirmation
f45439f
@gabrielew
Merge pull request #110 from gabrielew/2025-10-17/reload-only-changed…
22b905f 
…-slot-in-module

Avoid reloading prey module on confirmation dialogs
@gabrielew
fix: do not show active monster in list names
ae69ebb
@gabrielew
chore: remove unnecessary logs
122a814
@gabrielew
Reset prey slot state on type changes
1b635af
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 17, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@majestyotbr majestyotbr changed the title Feat/prey creatures html feat: prey creatures html Oct 17, 2025
kokekanon
kokekanon reviewed Oct 17, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 17, 2025

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Nov 17, 2025
libergod and others added 6 commits November 19, 2025 12:02
@libergod @kokekanon
Update modules/game_prey_html/game_prey_html.lua
de564fe 
Co-authored-by: kokekanon <114332266+kokekanon@users.noreply.github.com>
@libergod
Merge branch 'main' into pr/1380
29ef283
@libergod
Revert "Merge branch 'main' into pr/1380"
5783806 
This reverts commit 29ef283, reversing
changes made to de564fe.
@libergod
Merge remote-tracking branch 'upstream/main' into pr/1380
c040565
@libergod
Reapply "Merge branch 'main' into pr/1380"
2980d1c 
This reverts commit 5783806.
@libergod
fix: update after new ui
5d7b610 
still needs to fix small positioning problems.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 20, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions github-actions bot removed the Stale label Nov 20, 2025
@github-actions
Copy link

github-actions bot commented Dec 20, 2025

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Dec 20, 2025
@kokekanon kokekanon mentioned this pull request Mar 4, 2026
Closed
5 tasks
@majestyotbr majestyotbr reopened this Mar 15, 2026
@github-actions github-actions bot removed the Stale label Mar 17, 2026
nalejmizupy added a commit to nalejmizupy/otclient that referenced this pull request Mar 21, 2026
@nalejmizupy
Merge PR opentibiabr#1380: feat prey creatures html
e391a4b 
Resolve gameinterface.lua: keep NPC hi (<1511) and no-attack-on-NPC smart-click behavior from main.

Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kokekanon kokekanon kokekanon left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gabrielew @kokekanon @majestyotbr @mehah @libergod