PR #179 - Type hints for reasoning module + Mesa 4.x compatibility fixes #180
abhinavk0220
started this conversation in
Show and tell
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hey everyone! Wanted to share a quick update on PR #179.
What's in the PR
Added comprehensive type hints and Args/Returns docstrings to the
entire reasoning module
Reasoning,CoTReasoning,ReActReasoning,and
ReWOOReasoning. Small change individually but makes the codebasesignificantly easier to navigate for new contributors and IDE tooling.
The Mesa 4.x situation and why it keeps coming up
While syncing with upstream main before opening this PR, I noticed
that
mesa.spaceimports had crept back into several files — bothsource and test files. This is the same issue PR #153 addresses, but
it keeps resurfacing because contributors are still opening PRs written
against the old Mesa 3.x API, and when those get merged they bring
mesa.spaceback.My approach has been: rather than just fixing our own files and
moving on, each time I sync with upstream I do a full audit and fix
every regression I find source files, test files, conftest,
recording utilities, everything. The idea is to make the codebase
consistently Mesa 4.x-ready rather than having islands of fixed code
surrounded by broken imports.
This PR fixes:
mesa.space→mesa.discrete_space/mesa.experimental.continuous_spacein
llm_agent.py,inbuilt_tools.py,conftest.py, test filesmodel.steps→model._timeinrecord_model.py(Mesa 4.x step counter)Model(seed=42)→Model()intest_parallel_stepping.pySingleGrid/MultiGridbranches entirely frominbuilt_tools.pyThe long-term fix is obviously getting PR #153 merged, which addresses
this at the root. But until then, happy to keep catching these regressions.
PR: #179
Beta Was this translation helpful? Give feedback.
All reactions