Merge pull request #4484 from jenshnielsen/better_type_checking

Only allow missing imports for modules known to not have stubs

Author: jenshnielsen

pyproject.toml

@@ -78,6 +78,7 @@ test = [
     "deepdiff>=5.0.2",
     "hypothesis>=5.49.0",
     "lxml>=4.3.0",
+    "lxml-stubs>=0.4.0",
     "mypy>=0.971",
     "pytest>=6.0.0",
     "pytest-cov>=3.0.0",
@@ -87,6 +88,7 @@ test = [
     "pyqtgraph>=0.11.0", # pyqtgraph tests
     "PyQt5>=5.15.0", # pyqtgraph tests
     "PyVisa-sim>=0.4.0",
+    "slack-sdk>=3.4.2", # needed to typecheck slack extension
     "sphinx>=4.5.0",  # sphinx extension tests
     "types_requests>=0.1.8",
     "types-setuptools>=57.0.0",
@@ -134,7 +136,6 @@ profile = "black"
 strict_optional = true
 disallow_untyped_decorators = true
 disallow_any_generics = false
-ignore_missing_imports = true
 show_column_numbers = true
 warn_unused_ignores = true
 warn_unused_configs = true
@@ -165,6 +166,43 @@ module = [
 ]
 disallow_untyped_defs = false
 
+# these are packages that we import
+# but either don't have stubs or we
+# dont have them installed.
+[[tool.mypy.overrides]]
+module = [
+    "broadbean.*", # can be removed once broadbean 0.11 is available
+    "clr",
+    "deepdiff",
+    "gclib",
+    "IPython.*",
+    "ipywidgets",
+    "h5py",
+    "h5netcdf",
+    "hickle",
+    "jsonschema",
+    "lomentum.tools",
+    "matplotlib.*",
+    "mcl_RF_Switch_Controller64",
+    "opencensus.ext.azure.*",
+    "pandas.*",
+    "pythoncom",
+    "pyqtgraph.*",
+    "pywinusb.*",
+    "ruamel",
+    "spyder.utils.site",
+    "spyder_kernels.customize",
+    "System.IO",
+    "tqdm.*",
+    "uncertainties",
+    "win32com.*",
+    "win32con",
+    "win32gui",
+    "wrapt",
+    "zhinst.qcodes",
+]
+ignore_missing_imports = true
+
 [tool.pytest.ini_options]
 minversion = "6.0"
 junit_family = "legacy"

qcodes/extensions/slack.py

@@ -53,8 +53,8 @@
 from time import sleep
 
 from requests.exceptions import ConnectTimeout, HTTPError, ReadTimeout
-from requests.packages.urllib3.exceptions import ReadTimeoutError
 from slack_sdk import WebClient
+from urllib3.exceptions import ReadTimeoutError
 
 from qcodes import config as qc_config
 from qcodes.loops import active_data_set, active_loop

qcodes/instrument/sims/dummy.py

@@ -4,7 +4,7 @@
 #               terminator='\n', device_clear=False)
 from typing import Any
 
-import validators.validators as vals
+import qcodes.validators as vals
 
 from qcodes.instrument.visa import VisaInstrument
 

qcodes/instrument_drivers/HP/HP8133A.py

@@ -2,4 +2,4 @@
 Module left for backwards compatibility. Will be deprecated and removed eventually.
 """
 
-from HP_8133A import HP8133A
+from .HP_8133A import HP8133A

qcodes/instrument_drivers/HP/HP8753D.py

@@ -2,4 +2,4 @@
 Module left for backwards compatibility. Will be deprecated and removed eventually.
 """
 
-from HP_8753D import HP8753D
+from .HP_8753D import HP8753D