From bfb6805a7e7040cf17503a247c7ba046bac90c66 Mon Sep 17 00:00:00 2001
From: Miroslav Stastny <mistastn@microsoft.com>
Date: Tue, 26 Mar 2019 12:33:23 +0100
Subject: [PATCH 1/2] fix(MenuItem): Item separator - replace ::before with
 box-shadow

---
 .../teams/components/Menu/menuItemStyles.ts   | 33 +++++--------------
 1 file changed, 8 insertions(+), 25 deletions(-)

diff --git a/packages/react/src/themes/teams/components/Menu/menuItemStyles.ts b/packages/react/src/themes/teams/components/Menu/menuItemStyles.ts
index 016c60ad99..ffc737a3a2 100644
--- a/packages/react/src/themes/teams/components/Menu/menuItemStyles.ts
+++ b/packages/react/src/themes/teams/components/Menu/menuItemStyles.ts
@@ -76,30 +76,6 @@ const getFocusedStyles = ({
   }
 }
 
-const itemSeparator: ComponentSlotStyleFunction<MenuItemPropsAndState, MenuVariables> = ({
-  props,
-  variables: v,
-}): ICSSInJSStyle => {
-  const { iconOnly, pills, primary, underlined, vertical } = props
-
-  return (
-    !vertical &&
-    !pills &&
-    !underlined &&
-    !iconOnly && {
-      '::before': {
-        position: 'absolute',
-        content: '""',
-        top: 0,
-        right: 0,
-        width: pxToRem(1),
-        height: '100%',
-        ...(primary ? { background: v.primaryBorderColor } : { background: v.borderColor }),
-      },
-    }
-  )
-}
-
 const pointingBeak: ComponentSlotStyleFunction<MenuItemPropsAndState, MenuVariables> = ({
   props,
   variables: v,
@@ -162,6 +138,7 @@ const menuItemStyles: ComponentSlotStylesInput<MenuItemPropsAndState, MenuVariab
       isFromKeyboard,
       pills,
       pointing,
+      primary,
       secondary,
       underlined,
       vertical,
@@ -212,7 +189,13 @@ const menuItemStyles: ComponentSlotStylesInput<MenuItemPropsAndState, MenuVariab
           marginBottom: verticalPointingBottomMargin,
         }),
 
-      ...itemSeparator({ props, variables: v, theme, colors }),
+      // item separator
+      ...(!vertical &&
+        !pills &&
+        !underlined &&
+        !iconOnly && {
+          boxShadow: `-1px 0 0 0 ${primary ? v.primaryBorderColor : v.borderColor} inset`,
+        }),
 
       // active styles
       ...(active && {

From 5da347eef320ff7f500cd588d6bfe96340ce91cd Mon Sep 17 00:00:00 2001
From: Miroslav Stastny <mistastn@microsoft.com>
Date: Tue, 26 Mar 2019 14:31:54 +0100
Subject: [PATCH 2/2] Changelog

---
 CHANGELOG.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 66e0493d82..bd39cb049d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -17,6 +17,9 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 ## [Unreleased]
 
+### Fixes
+- Fix narration for `Menu` @miroslavstastny ([#1105](https://github.com/stardust-ui/react/pull/1105))
+
 <!--------------------------------[ v0.25.0 ]------------------------------- -->
 ## [v0.25.0](https://github.com/stardust-ui/react/tree/v0.25.0) (2019-03-26)
 [Compare changes](https://github.com/stardust-ui/react/compare/v0.24.0...v0.25.0)