From 4e88953d9618d3c801b6636d9c93e70cee1ce5d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20Lu=C4=8Div=C5=88=C3=A1k?= Date: Fri, 12 Jul 2019 10:07:00 +0200 Subject: [PATCH 1/7] fix icons in docs not rendered properly --- docs/src/views/Theming.tsx | 63 ++++++++++++++++++++++++++++++++++++-- 1 file changed, 60 insertions(+), 3 deletions(-) diff --git a/docs/src/views/Theming.tsx b/docs/src/views/Theming.tsx index 32af9d5963..d9f457824d 100644 --- a/docs/src/views/Theming.tsx +++ b/docs/src/views/Theming.tsx @@ -1,11 +1,23 @@ import * as React from 'react' import { NavLink } from 'react-router-dom' -import { Button, Icon, Provider, Text, Animation, Header } from '@stardust-ui/react' +import { + Button, + Icon, + Provider, + Text, + Animation, + Header, + ComponentStyleFunctionParam, +} from '@stardust-ui/react' import DocPage from '../components/DocPage/DocPage' import ExampleSnippet from '../components/ExampleSnippet/ExampleSnippet' import GuidesNavigationFooter from '../components/GuidesNavigationFooter' +type ThemingVariables = { + iconColor: string +} + export default () => (
@@ -87,7 +99,7 @@ export default () => ( render={() => ( <> - + )} /> @@ -97,12 +109,57 @@ export default () => ( the Provider.

+ + + + ({ + ...({color: v.iconColor}) + }) + } + } + }}> + + + + + + + `} render={() => ( <> - + ) => ({ + ...{ color: v.iconColor }, + }), + }, + }, + }} + > From e66e4bcbb6689b671312f34d4d65d9a31e81c9b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20Lu=C4=8Div=C5=88=C3=A1k?= Date: Tue, 16 Jul 2019 11:36:10 +0200 Subject: [PATCH 2/7] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3be8028e02..54f67a822c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -35,6 +35,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm - Make sidebar categories collapsible @lucivpav ([#1611](https://github.com/stardust-ui/react/pull/1611)) - Fix code in nesting themes section of theming examples @lucivpav ([#1616](https://github.com/stardust-ui/react/pull/1616)) - Make prototypes conditionally public and move them below Behaviors @lucivpav ([#1627](https://github.com/stardust-ui/react/pull/1627)) +- Fix code in component variables section of theming page @lucivpav ([#1625](https://github.com/stardust-ui/react/pull/1625)) ## [v0.34.1](https://github.com/stardust-ui/react/tree/v0.34.1) (2019-07-11) From 6b1fbee4d5eea923c1680f27fbda6fec24ec876d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20Lu=C4=8Div=C5=88=C3=A1k?= Date: Fri, 19 Jul 2019 14:38:31 +0200 Subject: [PATCH 3/7] improve changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4bf8bdb24a..54a39c2cd9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -44,7 +44,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm - Fix broken fragments on CodeSandbox @lucivpav ([#1655](https://github.com/stardust-ui/react/pull/1655)) - Improve a table with component props in docs @layershifter ([#1634](https://github.com/stardust-ui/react/pull/1634)) - Improve rendering performance for docs examples @Bugaa92 ([#1654](https://github.com/stardust-ui/react/pull/1654)) -- Fix code in component variables section of theming page @lucivpav ([#1625](https://github.com/stardust-ui/react/pull/1625)) +- Fix code in Component variables section of Theming page @lucivpav ([#1625](https://github.com/stardust-ui/react/pull/1625)) ## [v0.34.1](https://github.com/stardust-ui/react/tree/v0.34.1) (2019-07-11) From e35d119ef252dc45a2e3edcb1669037d95e63c4b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20Lu=C4=8Div=C5=88=C3=A1k?= Date: Fri, 26 Jul 2019 12:39:23 +0200 Subject: [PATCH 4/7] rework without styles --- docs/src/views/Theming.tsx | 56 +++++++++++--------------------------- 1 file changed, 16 insertions(+), 40 deletions(-) diff --git a/docs/src/views/Theming.tsx b/docs/src/views/Theming.tsx index d9f457824d..e0cd828347 100644 --- a/docs/src/views/Theming.tsx +++ b/docs/src/views/Theming.tsx @@ -1,14 +1,6 @@ import * as React from 'react' import { NavLink } from 'react-router-dom' -import { - Button, - Icon, - Provider, - Text, - Animation, - Header, - ComponentStyleFunctionParam, -} from '@stardust-ui/react' +import { Button, Icon, Provider, Text, Animation, Header } from '@stardust-ui/react' import DocPage from '../components/DocPage/DocPage' import ExampleSnippet from '../components/ExampleSnippet/ExampleSnippet' @@ -98,8 +90,8 @@ export default () => ( ( <> - - + + )} /> @@ -111,58 +103,42 @@ export default () => ( - - + + ({ - ...({color: v.iconColor}) - }) - } - } - }}> + }} + > - - + + `} render={() => ( <> - - + + ) => ({ - ...{ color: v.iconColor }, - }), + color: 'cornflowerblue', }, }, }} > - - + + From 2c7358a72303479f5a98fa29dd7977af392a3d91 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20Lu=C4=8Div=C5=88=C3=A1k?= Date: Fri, 26 Jul 2019 12:41:26 +0200 Subject: [PATCH 5/7] remove unnecessary code --- docs/src/views/Theming.tsx | 4 ---- 1 file changed, 4 deletions(-) diff --git a/docs/src/views/Theming.tsx b/docs/src/views/Theming.tsx index e0cd828347..cddc347660 100644 --- a/docs/src/views/Theming.tsx +++ b/docs/src/views/Theming.tsx @@ -6,10 +6,6 @@ import DocPage from '../components/DocPage/DocPage' import ExampleSnippet from '../components/ExampleSnippet/ExampleSnippet' import GuidesNavigationFooter from '../components/GuidesNavigationFooter' -type ThemingVariables = { - iconColor: string -} - export default () => (
From 2b3886ac927a3baefbc16ea814ef35eeb04f0025 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20Lu=C4=8Div=C5=88=C3=A1k?= Date: Mon, 29 Jul 2019 17:26:07 +0200 Subject: [PATCH 6/7] Update CHANGELOG.md --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dc45b1359c..ff1ff72de7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,8 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm ### Features - Expose `isFromKeyboard` in `Grid` component @sophieH29 ([#1729](https://github.com/stardust-ui/react/pull/1729)) +### Documentation +- Fix code in Component variables section of Theming page @lucivpav ([#1625](https://github.com/stardust-ui/react/pull/1625)) ## [v0.35.0](https://github.com/stardust-ui/react/tree/v0.35.0) (2019-07-26) @@ -69,7 +71,6 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm - Improve a table with component props in docs @layershifter ([#1634](https://github.com/stardust-ui/react/pull/1634)) - Improve rendering performance for docs examples @Bugaa92 ([#1654](https://github.com/stardust-ui/react/pull/1654)) - Add FAQ entry for `Flex`, `Grid`, `Layout`, `Box`, `Segment` @lucivpav ([#1646](https://github.com/stardust-ui/react/pull/1646)) -- Fix code in Component variables section of Theming page @lucivpav ([#1625](https://github.com/stardust-ui/react/pull/1625)) ## [v0.34.3](https://github.com/stardust-ui/react/tree/v0.34.3) (2019-07-23) From 8e3c2d787ae0b0de39541e65765d25b3cd5136f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20Lu=C4=8Div=C5=88=C3=A1k?= Date: Mon, 12 Aug 2019 18:06:26 +0200 Subject: [PATCH 7/7] remove value --- docs/src/views/Theming.tsx | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/docs/src/views/Theming.tsx b/docs/src/views/Theming.tsx index cddc347660..2e151213d7 100644 --- a/docs/src/views/Theming.tsx +++ b/docs/src/views/Theming.tsx @@ -97,27 +97,6 @@ export default () => ( the Provider.

- - - - - - - - - - - `} render={() => ( <>