From 18d50bdc0c2b9a977f6c392761674e849fa55051 Mon Sep 17 00:00:00 2001 From: Alexandru Buliga Date: Mon, 22 Oct 2018 19:27:25 +0200 Subject: [PATCH 1/3] fix(button): removed dotted outline in firefox --- CHANGELOG.md | 1 + src/themes/teams/staticStyles/normalizeCSS.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c9d4e91897..12cd688c14 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,6 +25,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm ### Fixes - Fix build on Windows @jurokapsiar ([#383](https://github.com/stardust-ui/react/pull/383)) +- Fix for dotted focus outline in Firefox for `Button` component @Bugaa92 ([#390](https://github.com/stardust-ui/react/pull/390)) ### Features - Export `mergeThemes` @levithomason ([#285](https://github.com/stardust-ui/react/pull/285)) diff --git a/src/themes/teams/staticStyles/normalizeCSS.ts b/src/themes/teams/staticStyles/normalizeCSS.ts index 5173dd5f68..70d3efc94d 100644 --- a/src/themes/teams/staticStyles/normalizeCSS.ts +++ b/src/themes/teams/staticStyles/normalizeCSS.ts @@ -215,7 +215,7 @@ button:-moz-focusring, [type="button"]:-moz-focusring, [type="reset"]:-moz-focusring, [type="submit"]:-moz-focusring { - outline: 1px dotted ButtonText; + outline: 0; } /** From 0f57318fccdc92d88cba1764c37d1c0d8faa0e34 Mon Sep 17 00:00:00 2001 From: Alexandru Buliga Date: Wed, 24 Oct 2018 14:44:21 +0200 Subject: [PATCH 2/3] addressed comments following suggestions --- docs/src/Style.ts | 7 +++++++ src/themes/teams/staticStyles/normalizeCSS.ts | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/docs/src/Style.ts b/docs/src/Style.ts index 1008bf1016..63591be984 100644 --- a/docs/src/Style.ts +++ b/docs/src/Style.ts @@ -37,4 +37,11 @@ export const semanticCssOverrides = ` color: rgba(255,255,255,.7)!important; cursor: not-allowed!important; } + + button:-moz-focusring, + [type="button"]:-moz-focusring, + [type="reset"]:-moz-focusring, + [type="submit"]:-moz-focusring { + outline: 0; + } ` diff --git a/src/themes/teams/staticStyles/normalizeCSS.ts b/src/themes/teams/staticStyles/normalizeCSS.ts index 70d3efc94d..5173dd5f68 100644 --- a/src/themes/teams/staticStyles/normalizeCSS.ts +++ b/src/themes/teams/staticStyles/normalizeCSS.ts @@ -215,7 +215,7 @@ button:-moz-focusring, [type="button"]:-moz-focusring, [type="reset"]:-moz-focusring, [type="submit"]:-moz-focusring { - outline: 0; + outline: 1px dotted ButtonText; } /** From 7b7a54108dbe8c3c101e28d51b97fd4a5bf230a5 Mon Sep 17 00:00:00 2001 From: kuzhelov Date: Tue, 30 Oct 2018 14:43:50 +0300 Subject: [PATCH 3/3] refine changelog entry --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c7b7d39acf..b83a22fdff 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,7 +27,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm - Do not render the Attachment's `progress` value to the DOM @levithomason ([#402](https://github.com/stardust-ui/react/pull/402)) - Add Segment background color @levithomason ([#408](https://github.com/stardust-ui/react/pull/408)) - Make `eventStack` subscription logic to be always async @kuzhelov ([#391](https://github.com/stardust-ui/react/pull/391)) -- Fix for dotted focus outline in Firefox for `Button` component @Bugaa92 ([#390](https://github.com/stardust-ui/react/pull/390)) +- Fix for dotted focus outline in Firefox for `Button` component in docs @Bugaa92 ([#390](https://github.com/stardust-ui/react/pull/390)) ### Features - Export `mergeThemes` @levithomason ([#285](https://github.com/stardust-ui/react/pull/285))