fixup! feat(scripts/monorepo): refactor getDependencies with collectDependencies function to return map array including tests

Author: Hotell

scripts/generators/copy-notices.js

@@ -19,9 +19,9 @@ async function copyNotices() {
 
   console.log(`NOTICE.txt exists in ${noticeFilePath}`);
 
-  const dependencyNames = (await monorepo.getDependencies('@fluentui/react-components')).dependencies;
-  const copyLocations = dependencyNames.map(dependencyName =>
-    path.resolve(monorepo.findGitRoot(), 'packages', dependencyName.replace('@fluentui/', ''), 'NOTICE.txt'),
+  const dependencies = (await monorepo.getDependencies('@fluentui/react-components')).dependencies;
+  const copyLocations = dependencies.map(dep =>
+    path.resolve(monorepo.findGitRoot(), 'packages', dep.name.replace('@fluentui/', ''), 'NOTICE.txt'),
   );
 
   console.log(`reading ${noticeFilePath}`);

scripts/monorepo/src/getDependencies.d.ts

@@ -3,7 +3,7 @@
 // This errors in strict ts check mode.
 
 /// <reference path="../../../typings/lerna/index.d.ts" />
-export declare function getDependencies(packageName: string | string[]): Promise<{
+export declare function getDependencies(packageName: string): Promise<{
   dependencies: Dependency[];
   devDependencies: Dependency[];
   all: Dependency[];

scripts/monorepo/src/getDependencies.js

@@ -61,20 +61,21 @@ function collectDependencies(
 }
 
 /**
- * Returns dependencies metadata build from dependency graph for provided package/s
- * @param {string | string[]} packageName - including `@fluentui/` prefix
+ * Returns dependencies metadata build from dependency graph for provided package
+ * @param {string} packageName - including `@fluentui/` prefix
  */
 async function getDependencies(packageName) {
-  const packagesToProcess = Array.isArray(packageName) ? packageName : [packageName];
+  const selfDependencyDefinition = /** @type const */ ({
+    name: packageName,
+    dependencyType: 'dependencies',
+    isTopLevel: true,
+  });
   const { projectGraph } = await lernaUtils.detectProjects();
 
-  const allDepsGraph = packagesToProcess
-    .map(projectName => collectDependencies(projectName, projectGraph, { shallow: false, dependenciesOnly: false }))
-    .flat();
-
-  const depsGraph = packagesToProcess
-    .map(projectName => collectDependencies(projectName, projectGraph, { shallow: false, dependenciesOnly: true }))
-    .flat();
+  const allDepsGraph = collectDependencies(packageName, projectGraph, { shallow: false, dependenciesOnly: false });
+  allDepsGraph.unshift(selfDependencyDefinition);
+  const depsGraph = collectDependencies(packageName, projectGraph, { shallow: false, dependenciesOnly: true });
+  depsGraph.unshift(selfDependencyDefinition);
   const devDepsGraph = allDepsGraph.filter(anyDep => !depsGraph.find(prodDep => prodDep.name === anyDep.name));
 
   return {

scripts/monorepo/src/getDependencies.spec.js

@@ -12,6 +12,11 @@ describe(`#getDependencies`, () => {
 
     expect(deps.dependencies).toMatchInlineSnapshot(`
       Array [
+        Object {
+          "dependencyType": "dependencies",
+          "isTopLevel": true,
+          "name": "@fluentui/react-text",
+        },
         Object {
           "dependencyType": "dependencies",
           "isTopLevel": true,

scripts/projects-test/src/packPackages.ts

@@ -38,7 +38,11 @@ export async function packProjectPackages(
 
   logger(`✔️ Used lerna config: ${workspaceRoot}`);
 
-  const { dependencies: requiredPackages, projectGraph } = await getDependencies(rootPackages);
+  if (rootPackages.length > 1) {
+    throw new Error('illegal API, we support only 1 package from now one!');
+  }
+
+  const { dependencies: requiredPackages, projectGraph } = await getDependencies(rootPackages[0]);
 
   logger(`✔️ Following packages will be packed:${requiredPackages.map(pkg => `\n${' '.repeat(30)}- ${pkg.name}`)}`);