From e266f20925e3fe1272ecf0a628530abf747136f2 Mon Sep 17 00:00:00 2001 From: Aniket Handa Date: Wed, 8 May 2019 17:13:14 -0700 Subject: [PATCH 1/3] Remove aria-hidden --- .../src/components/FocusTrapZone/FocusTrapZone.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/office-ui-fabric-react/src/components/FocusTrapZone/FocusTrapZone.tsx b/packages/office-ui-fabric-react/src/components/FocusTrapZone/FocusTrapZone.tsx index 5506d7b444ce9b..af8216b6312873 100644 --- a/packages/office-ui-fabric-react/src/components/FocusTrapZone/FocusTrapZone.tsx +++ b/packages/office-ui-fabric-react/src/components/FocusTrapZone/FocusTrapZone.tsx @@ -82,7 +82,6 @@ export class FocusTrapZone extends React.Component impl position: 'fixed' // 'fixed' prevents browsers from scrolling to bumpers when viewport does not contain them }, tabIndex: disabled ? -1 : 0, // make bumpers tabbable only when enabled - 'aria-hidden': true, 'data-is-visible': true } as React.HTMLAttributes; From 74af9fabece1205b050f9280892fda24cc524c04 Mon Sep 17 00:00:00 2001 From: Aniket Handa Date: Wed, 8 May 2019 17:29:05 -0700 Subject: [PATCH 2/3] Update snapshots --- .../HoverCard/__snapshots__/HoverCard.test.tsx.snap | 4 ---- .../components/Modal/__snapshots__/Modal.test.tsx.snap | 6 ------ .../components/Panel/__snapshots__/Panel.test.tsx.snap | 2 -- .../CommandBar.CommandBarButtonAs.Example.tsx.shot | 2 -- .../FocusTrapZone.Box.Click.Example.tsx.shot | 2 -- .../__snapshots__/FocusTrapZone.Box.Example.tsx.shot | 2 -- ...sTrapZone.Box.FocusOnCustomElement.Example.tsx.shot | 2 -- .../FocusTrapZone.FocusZone.Example.tsx.shot | 2 -- .../FocusTrapZone.Nested.Example.tsx.shot | 10 ---------- .../Panel.HiddenOnDismiss.Example.tsx.shot | 2 -- 10 files changed, 34 deletions(-) diff --git a/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap b/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap index 80d068b9800fef..799b23f87734ad 100644 --- a/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap +++ b/packages/office-ui-fabric-react/src/components/HoverCard/__snapshots__/HoverCard.test.tsx.snap @@ -142,7 +142,6 @@ exports[`HoverCard renders ExpandingCard correctly 1`] = ` onFocusCapture={[Function]} >
Date: Wed, 8 May 2019 17:32:32 -0700 Subject: [PATCH 3/3] Add rush change --- .../panel-focus_2019-05-09-00-32.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 common/changes/office-ui-fabric-react/panel-focus_2019-05-09-00-32.json diff --git a/common/changes/office-ui-fabric-react/panel-focus_2019-05-09-00-32.json b/common/changes/office-ui-fabric-react/panel-focus_2019-05-09-00-32.json new file mode 100644 index 00000000000000..0b8fff499ec185 --- /dev/null +++ b/common/changes/office-ui-fabric-react/panel-focus_2019-05-09-00-32.json @@ -0,0 +1,11 @@ +{ + "changes": [ + { + "packageName": "office-ui-fabric-react", + "comment": "Fix ARIA issue in Surfaces", + "type": "patch" + } + ], + "packageName": "office-ui-fabric-react", + "email": "anihan@microsoft.com" +} \ No newline at end of file