Address code review feedback.

brianrob · brianrob · commit e41560b78b64 · 2025-11-07T08:32:58.000-08:00
diff --git a/src/TraceEvent/DynamicTraceEventParser.cs b/src/TraceEvent/DynamicTraceEventParser.cs
@@ -533,9 +533,8 @@ private object GetPayloadValueAt(ref PayloadFetch payloadFetch, int offset, int
                     // input=Array of ulong
                     // output=Array of IntPtr
                     // This is common for bitmasks.  To address this, we special case it here.
-                    if (value is ulong && elementType == typeof(IntPtr))
+                    if (elementType == typeof(IntPtr) && value is ulong uintVal)
                     {
-                        ulong uintVal = (ulong)value;
                         value = new IntPtr(unchecked((long)uintVal));
                     }
                     else if (value.GetType() != elementType)

Original file line number	Diff line number	Diff line change
`@@ -533,9 +533,8 @@ private object GetPayloadValueAt(ref PayloadFetch payloadFetch, int offset, int`
`533`	`533`	`// input=Array of ulong`
`534`	`534`	`// output=Array of IntPtr`
`535`	`535`	`// This is common for bitmasks. To address this, we special case it here.`
`536`		`- if (value is ulong && elementType == typeof(IntPtr))`
	`536`	`+ if (elementType == typeof(IntPtr) && value is ulong uintVal)`
`537`	`537`	`{`
`538`		`- ulong uintVal = (ulong)value;`
`539`	`538`	`value = new IntPtr(unchecked((long)uintVal));`
`540`	`539`	`}`
`541`	`540`	`else if (value.GetType() != elementType)`