Skip to content

Commit 25ca277

Browse files
authored
test(video): add test for ffmpeg process cleanup with empty video (#39889)
1 parent 9377dab commit 25ca277

1 file changed

Lines changed: 28 additions & 0 deletions

File tree

tests/library/video.spec.ts

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -672,6 +672,34 @@ it.describe('screencast', () => {
672672
expect(videoPlayer.videoHeight).toBe(240);
673673
});
674674

675+
it('should close ffmpeg even if there were no frames', {
676+
annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/39872' }
677+
}, async ({ browserType }, testInfo) => {
678+
const size = { width: 320, height: 240 };
679+
const browser = await browserType.launch();
680+
681+
const videoDir = testInfo.outputPath('');
682+
const context = await browser.newContext({
683+
recordVideo: {
684+
dir: videoDir,
685+
size,
686+
},
687+
viewport: size,
688+
});
689+
690+
const page1 = await context.newPage();
691+
await page1.close();
692+
693+
const page2 = await context.newPage();
694+
await page2.close();
695+
696+
await context.close();
697+
await browser.close();
698+
699+
const videoFiles = findVideos(videoDir);
700+
expect(videoFiles.length).toBe(2);
701+
});
702+
675703
it('should not create video for internal pages', async ({ browser, server }, testInfo) => {
676704
server.setRoute('/empty.html', (req, res) => {
677705
res.setHeader('Set-Cookie', 'name=value');

0 commit comments

Comments
 (0)