Make the shell attach command customizable (#160)

* makes the shell attach command customizable

* added 'shell' to the command name

* fixed an error with fetching the settings

Author: Fredrik Folkesson

commands/open-shell-container.ts

@@ -5,9 +5,10 @@ import { ContainerNode } from '../explorer/models/containerNode';
 import { reporter } from '../telemetry/telemetry';
 const teleCmdId: string = 'vscode-docker.container.open-shell';
 
+const configOptions: vscode.WorkspaceConfiguration = vscode.workspace.getConfiguration('docker');
 const engineTypeShellCommands = {
-    [DockerEngineType.Linux]: "/bin/sh",
-    [DockerEngineType.Windows]: "powershell"
+    [DockerEngineType.Linux]: configOptions.get('attachShellCommand.linuxContainer', '/bin/sh'),
+    [DockerEngineType.Windows]: configOptions.get('attachShellCommand.windowsContainer', 'powershell')
 }
 
 export async function openShellContainer(context?: ContainerNode) {

package.json

@@ -352,6 +352,16 @@
             "error"
           ],
           "description": "Controls the diagnostic severity for flagging a Dockerfile with multiple HEALTHCHECK instructions."
+        },
+        "docker.attachShellCommand.linuxContainer": {
+          "type": "string",
+          "default": "/bin/sh",
+          "description": "Attach command to use for Linux containers"
+        },
+        "docker.attachShellCommand.windowsContainer": {
+          "type": "string",
+          "default": "powershell",
+          "description": "Attach command to use for Windows containers"
         }
       }
     },