extract context key usage into util

Author: jrieken

src/extension.ts

@@ -6,7 +6,7 @@
 import * as vscode from 'vscode';
 import { EditorHighlights } from './editorHighlights';
 import { History, HistoryItem } from './history';
-import { CallItem, CallsDirection, CallsModel, FileItem, getPreviewChunks, getRequestRange, ItemSource, ReferenceItem, ReferencesModel, RichCallsDirection } from './models';
+import { CallItem, CallsDirection, CallsModel, Context, FileItem, getPreviewChunks, getRequestRange, ItemSource, ReferenceItem, ReferencesModel, RichCallsDirection } from './models';
 import { TreeDataProviderWrapper, TreeItem } from './provider';
 
 export function activate(context: vscode.ExtensionContext) {
@@ -19,7 +19,7 @@ export function activate(context: vscode.ExtensionContext) {
 
     const revealView = async () => {
         // upon first interaction set the reference list as active and reveal it
-        await vscode.commands.executeCommand('setContext', 'reference-list.isActive', true);
+        await Context.IsActive.set(true);
         await vscode.commands.executeCommand(`${viewId}.focus`);
     };
 
@@ -42,8 +42,10 @@ export function activate(context: vscode.ExtensionContext) {
         // update state
         view.message = undefined;
         editorHighlights.setModel(model);
-        vscode.commands.executeCommand('setContext', 'reference-list.hasResult', Boolean(model));
-        vscode.commands.executeCommand('setContext', 'reference-list.source', model?.source);
+
+        // update context
+        Context.HasResult.set(Boolean(model));
+        Context.Source.set(model?.source);
 
         revealView();
         provider.update(newModel || history);

src/history.ts

@@ -4,6 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import * as vscode from 'vscode';
+import { Context } from './models';
 
 export class HistoryItem {
 
@@ -46,7 +47,7 @@ export class History {
             // sure to update the order for re-run queries
             this._items.delete(item.id);
             this._items.set(item.id, item);
-            vscode.commands.executeCommand('setContext', 'reference-list.hasHistory', true);
+            Context.HasHistory.set(true);
         }
     }
 
@@ -56,6 +57,6 @@ export class History {
 
     clear(): void {
         this._items.clear();
-        vscode.commands.executeCommand('setContext', 'reference-list.hasHistory', false);
+        Context.HasHistory.set(false);
     }
 }

src/models.ts

@@ -29,6 +29,21 @@ export function getPreviewChunks(doc: vscode.TextDocument, range: vscode.Range,
     return { before, inside, after };
 }
 
+export class Context<V> {
+
+    static IsActive = new Context<boolean>('reference-list.isActive');
+    static Source = new Context<ItemSource | 'callHierarchy' | undefined>('reference-list.source');
+    static HasResult = new Context<boolean>('reference-list.hasResult');
+    static HasHistory = new Context<boolean>('reference-list.hasHistory');
+    static CallHierarchyMode = new Context<'showOutgoing' | 'showIncoming'>('references-view.callHierarchyMode');
+
+    private constructor(readonly name: string) { }
+
+    async set(value: V) {
+        vscode.commands.executeCommand('setContext', this.name, value);
+    }
+}
+
 export const enum ItemSource {
     References = 'vscode.executeReferenceProvider',
     Implementations = 'vscode.executeImplementationProvider',
@@ -318,7 +333,7 @@ export class RichCallsDirection {
 
     set value(value: CallsDirection) {
         this._value = value;
-        vscode.commands.executeCommand('setContext', 'references-view.callHierarchyMode', this._value === CallsDirection.Incoming ? 'showIncoming' : 'showOutgoing');
+        Context.CallHierarchyMode.set(this._value === CallsDirection.Incoming ? 'showIncoming' : 'showOutgoing');
         this._mem.update(RichCallsDirection._key, value);
     }
 }