Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Conversation

@Neurrone
Copy link
Contributor

@Neurrone Neurrone commented Jun 16, 2020

/CC @isidorn

Fixes microsoft/vscode#97817

  • Move focus to the editor when showing references from the references view, call hierarchy and history.

@Neurrone
Copy link
Contributor Author

I'm fairly sure that this behaviour is desirable for the call hierarchy and find all references. But am not sure whether it would be for history. If it isn't I'll remove the change for the history item.

@isidorn
Copy link

isidorn commented Jun 16, 2020

Assigning to @jrieken for an intial review. Feel free to assign back to me if you would prefer that review this.

Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks!

@jrieken jrieken added this to the June 2020 milestone Jun 17, 2020
@jrieken jrieken merged commit ac60bce into microsoft:master Jun 17, 2020
@jrieken
Copy link
Member

jrieken commented Jun 22, 2020

This has actually caused microsoft/vscode#100726 and is the opposite of what has been done here. In other views (like explorer or search) we do not change focus on click (or the primary open gesture) but only on double click.

@Neurrone
Copy link
Contributor Author

Yeah, I thought about this but the tree view API doesn't allow implementing the approach the explorer tree uses because the capability is not exposed as far as I can tell.

I'm OK with reverting this first until a better solution is found.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hitting enter on results in the find all references tree should move focus to the corresponding line in the editor

3 participants