Skip to content

Commit a98de4e

Browse files
omajidnohwnd
andauthored
Dipose XmlReaders in Microsoft.TestPlatform.Common.RunSettings (#5100)
It probably makes no impact, but the XmlReaders are declared as IDisposable, so we should Dispose() them when done using them. Co-authored-by: Jakub Jareš <me@jakubjares.com>
1 parent 3a6c061 commit a98de4e

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/Microsoft.TestPlatform.Common/RunSettings.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public void LoadSettingsXml(string settings)
8080
}
8181

8282
using var stringReader = new StringReader(settings);
83-
var reader = XmlReader.Create(stringReader, XmlRunSettingsUtilities.ReaderSettings);
83+
using var reader = XmlReader.Create(stringReader, XmlRunSettingsUtilities.ReaderSettings);
8484
ValidateAndSaveSettings(reader);
8585
}
8686

@@ -91,7 +91,7 @@ public void LoadSettingsXml(string settings)
9191
public void InitializeSettingsProviders(string settings)
9292
{
9393
using var stringReader = new StringReader(settings);
94-
var reader = XmlReader.Create(stringReader, XmlRunSettingsUtilities.ReaderSettings);
94+
using var reader = XmlReader.Create(stringReader, XmlRunSettingsUtilities.ReaderSettings);
9595
ReadRunSettings(reader);
9696
}
9797

0 commit comments

Comments
 (0)