Skip to content

Conversation

@xige-16
Copy link
Contributor

@xige-16 xige-16 commented Jan 17, 2022

fix issue: #15209
/kind bug
Signed-off-by: xige-16 [email protected]

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Jan 17, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jan 17, 2022
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 17, 2022
@longjiquan
Copy link
Contributor

thx for finding out this bug. Maybe we should always use channel with cache?
/lgtm

@czs007
Copy link
Collaborator

czs007 commented Jan 17, 2022

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #15250 (9d67cab) into master (871e093) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15250      +/-   ##
==========================================
- Coverage   79.71%   79.69%   -0.03%     
==========================================
  Files         449      449              
  Lines       61244    61244              
==========================================
- Hits        48820    48807      -13     
- Misses      10091    10108      +17     
+ Partials     2333     2329       -4     
Impacted Files Coverage Δ
internal/proxy/impl.go 83.71% <100.00%> (-0.78%) ⬇️
...nternal/util/rocksmq/client/rocksmq/client_impl.go 75.63% <0.00%> (-1.69%) ⬇️
internal/indexnode/indexnode_mock.go 83.71% <0.00%> (-1.14%) ⬇️
internal/indexcoord/index_coord.go 79.08% <0.00%> (-0.30%) ⬇️
internal/querycoord/task.go 81.04% <0.00%> (-0.20%) ⬇️
internal/rootcoord/root_coord.go 79.26% <0.00%> (-0.13%) ⬇️
internal/indexcoord/meta_table.go 83.28% <0.00%> (+0.26%) ⬆️
internal/rootcoord/task.go 77.42% <0.00%> (+0.43%) ⬆️
internal/querycoord/task_scheduler.go 76.92% <0.00%> (+0.59%) ⬆️
... and 3 more

@mergify mergify bot added the ci-passed label Jan 17, 2022
@sre-ci-robot sre-ci-robot merged commit 408a6e9 into milvus-io:master Jan 17, 2022
@xige-16 xige-16 deleted the fix-search-error-after branch July 14, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants