-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add retry logic in pulsar consumer unsubscribe #15284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry logic in pulsar consumer unsubscribe #15284
Conversation
|
@congqixia E2e jenkins job failed, comment |
|
/lgtm |
|
@congqixia E2e jenkins job failed, comment |
5 similar comments
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia E2e jenkins job failed, comment |
Signed-off-by: Congqi Xia <[email protected]>
f1b522f to
9116ca1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@congqixia E2e jenkins job failed, comment |
1 similar comment
|
@congqixia E2e jenkins job failed, comment |
|
/run-checks |
|
@congqixia E2e jenkins job failed, comment |
|
/run-checks |
|
@congqixia E2e jenkins job failed, comment |
1 similar comment
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia E2e jenkins job failed, comment |
10 similar comments
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia E2e jenkins job failed, comment |
Codecov Report
@@ Coverage Diff @@
## master #15284 +/- ##
==========================================
+ Coverage 79.63% 79.71% +0.08%
==========================================
Files 450 450
Lines 61441 61445 +4
==========================================
+ Hits 48928 48982 +54
+ Misses 10168 10121 -47
+ Partials 2345 2342 -3
|
Add retry logic in pulsar consumer
Unsubscribe.Tested with until fail script, works find in tens of minutes without failure with current retry setting.
Also remove panic logic when unsubscribe fails since the cost is too huge.
/cc @bigsheeper @xiaofan-luan
/kind bug
Fix #15280
Signed-off-by: Congqi Xia [email protected]