Skip to content

Conversation

@congqixia
Copy link
Contributor

Add retry logic in pulsar consumer Unsubscribe.
Tested with until fail script, works find in tens of minutes without failure with current retry setting.

Also remove panic logic when unsubscribe fails since the cost is too huge.

/cc @bigsheeper @xiaofan-luan
/kind bug

Fix #15280

Signed-off-by: Congqi Xia [email protected]

@sre-ci-robot sre-ci-robot added kind/bug Issues or changes related a bug approved size/S Denotes a PR that changes 10-29 lines. labels Jan 18, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jan 18, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

/lgtm

@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

5 similar comments
@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@congqixia congqixia force-pushed the unsubscribe_retry_nopanic branch from f1b522f to 9116ca1 Compare January 18, 2022 11:43
@sre-ci-robot sre-ci-robot removed the lgtm label Jan 18, 2022
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bigsheeper
Copy link
Contributor

/lgtm

@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@yanliang567
Copy link
Contributor

/run-checks

@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@yanliang567
Copy link
Contributor

/run-checks

@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

10 similar comments
@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2022

@congqixia E2e jenkins job failed, comment /run-checks can trigger the job again.

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #15284 (9116ca1) into master (bbb672c) will increase coverage by 0.08%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15284      +/-   ##
==========================================
+ Coverage   79.63%   79.71%   +0.08%     
==========================================
  Files         450      450              
  Lines       61441    61445       +4     
==========================================
+ Hits        48928    48982      +54     
+ Misses      10168    10121      -47     
+ Partials     2345     2342       -3     
Impacted Files Coverage Δ
internal/util/mqclient/pulsar_consumer.go 90.78% <80.00%> (-0.88%) ⬇️
internal/util/flowgraph/node.go 72.26% <0.00%> (-0.85%) ⬇️
internal/rootcoord/root_coord.go 79.38% <0.00%> (+0.12%) ⬆️
internal/querycoord/task.go 80.20% <0.00%> (+0.19%) ⬆️
internal/querycoord/task_scheduler.go 75.38% <0.00%> (+0.35%) ⬆️
internal/proxy/impl.go 84.48% <0.00%> (+0.49%) ⬆️
internal/msgstream/mq_msgstream.go 75.54% <0.00%> (+0.77%) ⬆️
internal/datacoord/segment_manager.go 82.81% <0.00%> (+1.03%) ⬆️
internal/distributed/querycoord/client/client.go 72.13% <0.00%> (+2.18%) ⬆️
internal/indexnode/indexnode_mock.go 87.87% <0.00%> (+3.03%) ⬆️
... and 1 more

@mergify mergify bot added the ci-passed label Jan 19, 2022
@sre-ci-robot sre-ci-robot merged commit 1e61112 into milvus-io:master Jan 19, 2022
@congqixia congqixia deleted the unsubscribe_retry_nopanic branch March 3, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: internal/msgstream unittest panics randomly

5 participants