Skip to content

Conversation

@junjiejiangjjj
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 53.40909% with 41 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (2.6@1766729). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pymilvus/client/async_grpc_handler.py 28.57% 15 Missing ⚠️
pymilvus/grpc_gen/common_pb2.py 8.33% 11 Missing ⚠️
pymilvus/milvus_client/async_milvus_client.py 33.33% 6 Missing ⚠️
pymilvus/milvus_client/milvus_client.py 33.33% 6 Missing ⚠️
pymilvus/client/prepare.py 84.21% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             2.6    #3080   +/-   ##
======================================
  Coverage       ?   46.36%           
======================================
  Files          ?       66           
  Lines          ?    14011           
  Branches       ?        0           
======================================
  Hits           ?     6496           
  Misses         ?     7515           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Nov 18, 2025
@junjiejiangjjj
Copy link
Contributor Author

/assign @XuanYang-cn

@junjiejiangjjj junjiejiangjjj marked this pull request as draft November 19, 2025 03:51
@junjiejiangjjj junjiejiangjjj force-pushed the func-2.6-patch branch 3 times, most recently from 94bdc94 to 79270fe Compare December 8, 2025 09:55
@junjiejiangjjj junjiejiangjjj marked this pull request as ready for review December 8, 2025 09:59
Signed-off-by: junjie.jiang <[email protected]>
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: junjiejiangjjj, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 129ec7c into milvus-io:2.6 Dec 9, 2025
13 checks passed
@pymilvus-bot
Copy link
Collaborator

⚠️ Backport Skipped
Hi @junjiejiangjjj, this PR modifies pymilvus/grpc_gen/. Please backport manually.

(cc @sre-ci-robot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants