Skip to content

chore: create exclusions for nyc#5609

Merged
mark-wiemer merged 2 commits intomochajs:mainfrom
lennonnikolas:nlennon/bugfix/5558_update_nyc
Jan 4, 2026
Merged

chore: create exclusions for nyc#5609
mark-wiemer merged 2 commits intomochajs:mainfrom
lennonnikolas:nlennon/bugfix/5558_update_nyc

Conversation

@lennonnikolas
Copy link
Copy Markdown
Contributor

PR Checklist

Overview

Will now exclude package-lock.json, node_modules, and test directory from nyc coverage

Will now exclude package-lock.json, node_modules, and test directory from nyc coverage
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.98%. Comparing base (1544c39) to head (8462a69).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5609      +/-   ##
==========================================
- Coverage   93.53%   87.98%   -5.55%     
==========================================
  Files          57       67      +10     
  Lines        4472     4754     +282     
  Branches      922      964      +42     
==========================================
  Hits         4183     4183              
- Misses        289      571     +282     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lennonnikolas lennonnikolas marked this pull request as draft January 4, 2026 04:24
@mark-wiemer
Copy link
Copy Markdown
Member

LGTM, @lennonnikolas let me know if there is anything preventing us from merging this one :)

@lennonnikolas lennonnikolas marked this pull request as ready for review January 4, 2026 14:11
@lennonnikolas
Copy link
Copy Markdown
Contributor Author

LGTM, @lennonnikolas let me know if there is anything preventing us from merging this one :)

Nothing out of the ordinary for me!

@mark-wiemer mark-wiemer merged commit 702473a into mochajs:main Jan 4, 2026
79 of 80 checks passed
@lennonnikolas lennonnikolas deleted the nlennon/bugfix/5558_update_nyc branch January 4, 2026 16:42
lennonnikolas added a commit to lennonnikolas/mocha that referenced this pull request Jan 24, 2026
@jedwards1211
Copy link
Copy Markdown
Contributor

jedwards1211 commented Jan 26, 2026

@mark-wiemer @lennonnikolas this PR added an nyc stanza in package.json instead of modifying or replacing the existing .nycrc file, I think this was a mistake? Shouldn't there only be one or the other? I'm pretty sure package.json stanza overrides the separate config files, though nyc's docs don't say for sure. There are many more exclusions in the existing .nycrc than what was added in this PR.

@lennonnikolas
Copy link
Copy Markdown
Contributor Author

@mark-wiemer @lennonnikolas this PR added an nyc stanza in package.json instead of modifying or replacing the existing .nycrc file, I think this was a mistake? Shouldn't there only be one or the other? I'm pretty sure package.json stanza overrides the separate config files, though nyc's docs don't say for sure. There are many more exclusions in the existing .nycrc than what was added in this PR.

Yeah the world of never-ending configurations. To be honest I overlooked this file. I'm newer to open source development. We can definitely migrate to the already existing RC file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🛠 Repo: Code coverage includes package-lock.json

3 participants