build(docs/dev-deps): use JS-native fetch to get supporters data instead of external needle#5643
Conversation
…stead of external `needle` Signed-off-by: hainenber <dotronghai96@gmail.com>
|
👋 Hi @hainenber, thanks for the pull request! A scan flagged a concern with it. Could you please take a look? [text-image-alt-text] The following image seems to have default alt text, rather than something informative:
Alternative text, or "alt text", is a description attached to an image. It allows non-sighted users and tools to understand the image despite not being able to visually see it. To resolve this report, add descriptive alt text to the image.
|
Signed-off-by: hainenber <dotronghai96@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5643 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 66 66
Lines 4787 4787
Branches 977 977
=======================================
Hits 4232 4232
Misses 555 555 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you! We'll probably merge this early next week unless @JoshuaKGoldberg has concerns. It does work when I repro locally, exact same result :) From local build:
|
|
All reports are resolved now. Thanks! ✅
|
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Hell yeah, thanks! This was bugging me back when I last worked on the scripts. 🙂
…stead of external `needle` (mochajs#5643) * build(docs/dev-deps): use JS-native `fetch` to get supporters data instead of external `needle` Signed-off-by: hainenber <dotronghai96@gmail.com> * chore: fix Prettier lint issue Signed-off-by: hainenber <dotronghai96@gmail.com> --------- Signed-off-by: hainenber <dotronghai96@gmail.com>

PR Checklist
status: accepting prsOverview
Pretty much as the PR's title and linked issue. There are no breakages when fetching supporter data (last zero indicates non-error exit signal from
npm run generatecommand indocs-next)