Skip to content

build(docs/dev-deps): use JS-native fetch to get supporters data instead of external needle#5643

Merged
JoshuaKGoldberg merged 2 commits intomochajs:mainfrom
hainenber:feat/migrate-needle-to-node-native-fetch
Jan 16, 2026
Merged

build(docs/dev-deps): use JS-native fetch to get supporters data instead of external needle#5643
JoshuaKGoldberg merged 2 commits intomochajs:mainfrom
hainenber:feat/migrate-needle-to-node-native-fetch

Conversation

@hainenber
Copy link
Copy Markdown
Contributor

@hainenber hainenber commented Jan 11, 2026

PR Checklist

Overview

Pretty much as the PR's title and linked issue. There are no breakages when fetching supporter data (last zero indicates non-error exit signal from npm run generate command in docs-next)

image

…stead of external `needle`

Signed-off-by: hainenber <dotronghai96@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 11, 2026

👋 Hi @hainenber, thanks for the pull request! A scan flagged a concern with it. Could you please take a look?

[text-image-alt-text] The following image seems to have default alt text, rather than something informative:

<img width="913" height="160" alt="image" src="https://github.com/user-attachments/assets/533b35e7-3b71-46d3-bc6c-250404d33b32" />

Alternative text, or "alt text", is a description attached to an image. It allows non-sighted users and tools to understand the image despite not being able to visually see it. To resolve this report, add descriptive alt text to the image.

🗺️ This message was posted automatically by OctoGuide: a bot for GitHub repository best practices.

Signed-off-by: hainenber <dotronghai96@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.40%. Comparing base (0ed524a) to head (af245f6).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5643   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files          66       66           
  Lines        4787     4787           
  Branches      977      977           
=======================================
  Hits         4232     4232           
  Misses        555      555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mark-wiemer
Copy link
Copy Markdown
Member

mark-wiemer commented Jan 11, 2026

Thank you! We'll probably merge this early next week unless @JoshuaKGoldberg has concerns. It does work when I repro locally, exact same result :)

From local build:

screenshot of working supporters section

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 11, 2026

All reports are resolved now. Thanks! ✅

🗺️ This message was posted automatically by OctoGuide: a bot for GitHub repository best practices.

Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yeah, thanks! This was bugging me back when I last worked on the scripts. 🙂

@JoshuaKGoldberg JoshuaKGoldberg merged commit e37e56f into mochajs:main Jan 16, 2026
79 of 80 checks passed
@hainenber hainenber deleted the feat/migrate-needle-to-node-native-fetch branch January 16, 2026 14:41
lennonnikolas pushed a commit to lennonnikolas/mocha that referenced this pull request Jan 24, 2026
…stead of external `needle` (mochajs#5643)

* build(docs/dev-deps): use JS-native `fetch` to get supporters data instead of external `needle`

Signed-off-by: hainenber <dotronghai96@gmail.com>

* chore: fix Prettier lint issue

Signed-off-by: hainenber <dotronghai96@gmail.com>

---------

Signed-off-by: hainenber <dotronghai96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🛠️ Repo: Use JS-native Fetch API to get supporter data from OpenCollective

3 participants