cryptonote_basic: fix add_extra_nonce_to_tx_extra() length #10220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffro256
force-pushed
the
fix_extra_nonce_len
branch
from
c9d3df2 to
980edf9
Compare
Contributor
Author
|
Unit test failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialization/deserialization code in$[128, 256)$ , these two sections diverge. This commit amends
tx_extra.htreats the nonce length as a varint, butcryptonote::add_extra_nonce_to_tx_extra()writes the nonce length as a raw unsigned 8-bit integer. For nonce sizes incryptonote::add_extra_nonce_to_tx_extra()to match the serialization code.Issue identified by the Monero Oxide project and reporters.