Skip to content

Commit 81a0f49

Browse files
committed
Promote the new --devtools command line argument and link to debugging online documentation
1 parent 94989fa commit 81a0f49

3 files changed

Lines changed: 14 additions & 3 deletions

File tree

src/cmd/run.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ export default async function run(
9393
target,
9494
args,
9595
firefoxPreview = [],
96+
verbose = false,
9697
// Android CLI options.
9798
adbBin,
9899
adbHost,
@@ -165,6 +166,7 @@ export default async function run(
165166
startUrl,
166167
args,
167168
desktopNotifications,
169+
verbose,
168170
};
169171

170172
if (!target || target.length === 0 || target.includes('firefox-desktop')) {

src/extension-runners/firefox-desktop.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ export class FirefoxDesktopExtensionRunner {
214214
const {
215215
browserConsole,
216216
devtools,
217+
verbose,
217218
extensions,
218219
firefoxBinary,
219220
preInstall,
@@ -243,6 +244,8 @@ export class FirefoxDesktopExtensionRunner {
243244
firefoxBinary,
244245
binaryArgs,
245246
extensions,
247+
verbose,
248+
devtools,
246249
});
247250

248251
this.runningInfo.firefox.on('close', () => {

src/firefox/index.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,8 @@ export async function run(
103103
firefoxBinary,
104104
binaryArgs,
105105
extensions,
106+
devtools,
107+
verbose,
106108
}: FirefoxRunOptions = {}
107109
): Promise<FirefoxInfo> {
108110

@@ -164,9 +166,13 @@ export async function run(
164166
throw error;
165167
});
166168

167-
log.info(
168-
'Use --verbose or open Tools > Web Developer > Browser Console ' +
169-
'to see logging');
169+
if (!verbose && !devtools) {
170+
log.info('Use --verbose or --devtools to see logging');
171+
}
172+
if (devtools) {
173+
log.info("More info about WebExtension debugging:");
174+
log.info("https://extensionworkshop.com/documentation/develop/debugging/");
175+
}
170176

171177
firefox.stderr.on('data', (data) => {
172178
log.debug(`Firefox stderr: ${data.toString().trim()}`);

0 commit comments

Comments
 (0)