Add support for Galaxy S5 Active (SM-G870x)#569
Open
DavPow16 wants to merge 3 commits intomsm8916-mainline:mainfrom
Open
Add support for Galaxy S5 Active (SM-G870x)#569DavPow16 wants to merge 3 commits intomsm8916-mainline:mainfrom
DavPow16 wants to merge 3 commits intomsm8916-mainline:mainfrom
Conversation
wonderfulShrineMaidenOfParadise
suggested changes
Aug 22, 2025
lk2nd/device/dts/msm8974/samsung.dts
Outdated
Comment on lines
+155
to
+175
| model = "Samsung Galaxy S5 Active (SM-G870x)"; | ||
| compatible = "samsung,klteactivexx", "samsung,klte"; | ||
| lk2nd,match-bootloader = "G870*"; | ||
| lk2nd,dtb-files = "msm8974pro-samsung-klte"; | ||
|
|
||
| gpio-keys { | ||
| compatible = "gpio-keys"; | ||
| home { | ||
| lk2nd,code = <KEY_HOME>; | ||
| gpios = <&pmic 3 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; | ||
| }; | ||
| down { | ||
| lk2nd,code = <KEY_VOLUMEDOWN>; | ||
| gpios = <&pmic 2 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; | ||
| }; | ||
| up { | ||
| lk2nd,code = <KEY_VOLUMEUP>; | ||
| gpios = <&pmic 5 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; | ||
| }; | ||
| }; | ||
| }; |
Contributor
There was a problem hiding this comment.
Suggested change
| model = "Samsung Galaxy S5 Active (SM-G870x)"; | |
| compatible = "samsung,klteactivexx", "samsung,klte"; | |
| lk2nd,match-bootloader = "G870*"; | |
| lk2nd,dtb-files = "msm8974pro-samsung-klte"; | |
| gpio-keys { | |
| compatible = "gpio-keys"; | |
| home { | |
| lk2nd,code = <KEY_HOME>; | |
| gpios = <&pmic 3 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; | |
| }; | |
| down { | |
| lk2nd,code = <KEY_VOLUMEDOWN>; | |
| gpios = <&pmic 2 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; | |
| }; | |
| up { | |
| lk2nd,code = <KEY_VOLUMEUP>; | |
| gpios = <&pmic 5 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; | |
| }; | |
| }; | |
| }; | |
| model = "Samsung Galaxy S5 Active (SM-G870x)"; | |
| compatible = "samsung,klteactivexx", "samsung,klte"; | |
| lk2nd,match-bootloader = "G870*"; | |
| lk2nd,dtb-files = "msm8974pro-samsung-klte"; | |
| gpio-keys { | |
| compatible = "gpio-keys"; | |
| home { | |
| lk2nd,code = <KEY_HOME>; | |
| gpios = <&pmic 3 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; | |
| }; | |
| down { | |
| lk2nd,code = <KEY_VOLUMEDOWN>; | |
| gpios = <&pmic 2 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; | |
| }; | |
| up { | |
| lk2nd,code = <KEY_VOLUMEUP>; | |
| gpios = <&pmic 5 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; | |
| }; | |
| }; |
Use tabs for indents.
lk2nd/device/dts/msm8974/samsung.dts
Outdated
| }; | ||
| }; | ||
|
|
||
| /* rev 01 */ |
Contributor
There was a problem hiding this comment.
rev 01 is supposed to be put before rev 10 and rev 14
lk2nd/device/dts/msm8974/samsung.dts
Outdated
| }; | ||
| }; | ||
| }; | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
lk2nd/device/dts/msm8974/samsung.dts
Outdated
| }; | ||
|
|
||
| &lk2nd { | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
TravMurav
reviewed
Aug 25, 2025
| kltecanactive { | ||
| model = "Samsung Galaxy S5 Active (SM-G870x)"; | ||
| compatible = "samsung,klteactivexx", "samsung,klte"; | ||
| lk2nd,match-bootloader = "G870*"; |
Member
There was a problem hiding this comment.
The indentation is a bit broken here.. I'd appreciate if you could tab the contents of the node out and correct the last closing bracket accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#55 (comment)
Hello,
Thanks to this comment I was able to get lk2nd working on my Canadian Galaxy S5 Active (SM-G870W).
I guess it should work on other variants of the S5 Active but I have no way of testing.
SoC revision of my particular unit was
1so adding this toqcom,msm-idgot it working.This is literally my first time forking/pulling anything on GitHub and I am also not a programmer so please let me know if I did anything wrong or if you need more info :)