feat: add diode-replay-dryrun helper#33
Merged
leoparente merged 6 commits intodevelopfrom Jul 14, 2025
Merged
Conversation
|
Go test coverage
Total coverage: 76.7% |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Introduces a new CLI tool for replaying dry-run JSON files to a Diode service and updates project dependencies.
- Adds
diode-replay-dryrunCLI incmd/diode-replay-dryrun/main.gowith flags for files, target, app info, and OAuth2 credentials. - Updates
go.modto makegolang.org/x/neta direct dependency. - Documents installation and usage of the new CLI in
README.md.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Promote golang.org/x/net to a direct requirement |
| cmd/diode-replay-dryrun/main.go | Implement the CLI tool for ingesting dry-run JSON files |
| README.md | Add documentation and usage examples for the new CLI helper |
Comments suppressed due to low confidence (3)
cmd/diode-replay-dryrun/main.go:27
- [nitpick] The variable name
versionis ambiguous; consider renaming it toappVersionfor consistency with the flag name and to improve clarity.
version := flag.String("app-version", "", "Application version used when ingesting the dry-run messages")
cmd/diode-replay-dryrun/main.go:22
- Consider adding unit or integration tests for the CLI tool to verify flag parsing and ingestion behavior.
func main() {
README.md:179
- [nitpick] The example target path (
/diode) differs from the flag description example (/diodet); update one for consistency.
--target grpc://localhost:8080/diode \
jajeffries
approved these changes
Jul 11, 2025
Co-authored-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
mfiedorowicz
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new CLI tool,
diode-replay-dryrun, to replay dry-run files generated by theDryRunClientand send them to a Diode service. It also updates the project dependencies ingo.mod. Below are the most important changes:Addition of the
diode-replay-dryrunCLI ToolREADME.mdexplaining the purpose of thediode-replay-dryruntool, installation instructions, and usage examples. The tool supports ingesting multiple JSON files and provides flexibility in specifying OAuth2 credentials via flags or environment variables.main.gofile for the CLI tool, which includes:diodeSDK.Dependency Updates
go.modChanges: Updated thegolang.org/x/netdependency to be a direct requirement instead of indirect. This ensures compatibility with the new CLI tool.