Merged
Conversation
|
Go test coverage
Total coverage: 76.1% |
mfiedorowicz
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors error handling and logging in the
cmd/diode-replay-dryrun/main.gofile to improve clarity and consistency. It replaceslogwithfmtfor better control over output streams and updates error messages for improved user feedback.Error handling improvements:
log.Fatalwithfmt.Fprintfto print errors toos.Stderrand explicitly exit the program withos.Exit(1)for better control over error handling.Logging improvements:
log.Printfwithfmt.Fprintfto direct output to the appropriate streams (os.Stderrfor errors,os.Stdoutfor success messages).Minor updates:
-targetflag description to fix a typo in the example URL.logimport and replaced it withfmt.