Merged
Conversation
github-actions
bot
added
documentation
|
Go test coverage
Total coverage: 74.8% |
leoparente
requested review from
MicahParks,
jajeffries,
ltucker and
mfiedorowicz
as code owners
jajeffries
approved these changes
Oct 29, 2025
Co-authored-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Co-authored-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Co-authored-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Co-authored-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Co-authored-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Co-authored-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
mfiedorowicz
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for exporting entities as OpenTelemetry (OTLP) log records via a new
OTLPClient, allowing integration with OTLP collectors over gRPC. It also introduces comprehensive tests for the new client and updates several dependencies to support OTLP functionality.New OTLP client functionality:
OTLPClientimplementation indiode/otlp_client.goto convert ingestion entities into OTLP log records and export them over gRPC, including support for TLS, custom timeouts, and error handling viaOTLPClientError.README.mdto describe the new OTLP client usage, configuration, and error handling.Testing and validation:
diode/otlp_client_test.gowith unit tests covering successful log export, error wrapping, and client validation for supported schemes.Dependency updates:
go.modto addgo.opentelemetry.io/proto/otlpand bump related dependencies (google.golang.org/grpc,google.golang.org/protobuf, etc.) for OTLP compatibility.