Conversation
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
|
Go test coverage
Total coverage: 76.6% |
jajeffries
reviewed
Nov 17, 2025
jajeffries
approved these changes
Nov 17, 2025
Contributor
jajeffries
left a comment
There was a problem hiding this comment.
Overall looks good, but one minor suggestion about the dry run client
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
leoparente
approved these changes
Nov 17, 2025
jajeffries
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for attaching custom metadata to ingestion requests and entities in the Diode Go SDK. Users can now provide additional context or tracking information at both the entity and request level, and this metadata is preserved across gRPC, dry run, and OTLP export flows. The documentation and test suite have been updated to demonstrate and verify these new capabilities.
Metadata support and API changes:
WithIngestMetadataoption and supporting types to allow passing metadata (as key-value pairs) withIngestandIngestProtocalls in bothGRPCClientandDryRunClient. This metadata is attached to theIngestRequestand serialized as a protobuf struct. [1] [2] [3] [4]Documentation improvements:
README.mdwith detailed usage examples for entity-level and request-level metadata, including how metadata is handled in dry run and OTLP export scenarios. [1] [2] [3]Testing enhancements:
Ingest,IngestProto, and dry run flows, including tests for various metadata types (primitives, arrays, nested objects, and edge cases). Ensured that metadata is correctly serialized and included in requests. [1] [2]Internal codebase updates:
These changes make the SDK more flexible and extensible for tracking, auditing, and enriching ingested data with custom attributes.